Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by RChardakov · Feb 17, 2013 at 10:36 PM · nullreferenceexception

NullReferenceException

NullReferenceException: Object reference not set to an instance of an object EnemyAttack.Attack () (at Assets/Scripts/EnemyAttack.cs:43) EnemyAttack.Update () (at Assets/Scripts/EnemyAttack.cs:25) After i hit play and the evil cube tries to attack me

basicli i m learning from the berg zerg arcade tutorials and i've been good so far but now i get this error NullReferenceException: Object reference not set to an instance of an object EnemyAttack.Attack () (at Assets/Scripts/EnemyAttack.cs:43) EnemyAttack.Update () (at Assets/Scripts/EnemyAttack.cs:25) After i hit play and the evil cube tries to attack me here is my script please help me

 using UnityEngine;
 using System.Collections;
 
 public class EnemyAttack : MonoBehaviour {
     public GameObject target;
     public float attackTimer;
     public float coolDown;
 
     // Use this for initialization
     void Start () {
         attackTimer = 0;
         coolDown = 2.0f;
     
     }
 
     // Update is called once per frame
     void Update () {
         if(attackTimer > 0)
             attackTimer -= Time.deltaTime;
         
         if(attackTimer <0)
             attackTimer = 0;
 
         if(attackTimer == 0){
             Attack();
             attackTimer = coolDown;
         }
 }
         private    void Attack() {;
             
         float distance = Vector3.Distance(target.transform.position, transform.position);
         
         Vector3 dir = (target.transform.position - transform.position).normalized;
         
         float direction = Vector3.Dot(dir, transform.forward);
         
         Debug.Log(direction);
         
         if(distance < 2.5f) {
             if(direction > 0) {
         
     PlayerHealth ph = (PlayerHealth)target.GetComponent("EnemyHealth");
     ph.AddjustCurrentHealth(-10);
                                 }    
                             }
                            }
                     }
Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

2 Replies

· Add your reply
  • Sort: 
avatar image
0
Best Answer

Answer by iwaldrop · Feb 17, 2013 at 10:41 PM

The line number of the error is telling you that it hasn't found PlayerHealth ph. There probably isn't one on your target. You should build in protections for this kind of thing so that you never get error messages, and so that you can handle cases where a component you're looking for isn't found.

     PlayerHealth ph = (PlayerHealth)target.GetComponent("EnemyHealth");
     if (ph != null)
         ph.AddjustCurrentHealth(-10);
     else
         // do something if PlayHealth is not found
Comment
Add comment · Show 3 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Starkid225 · Feb 17, 2013 at 10:50 PM 0
Share

Also on line 29 be sure to remove that semicolon at the end of the line. Hope that helps...

avatar image RChardakov · Feb 20, 2013 at 08:11 PM 0
Share

can you give me an example how to to make it so if it does not find it to try to find it again or something else wich will be helpful btw thank you very much this is my home porject i have a project for school and i m learing much more :) the only way to really remeber something is to get it wrong the first time :) please respond quickly :)

avatar image iwaldrop · Feb 21, 2013 at 04:22 AM 0
Share

Well that's exactly what I already did up there. The code (above) says that we're going to find a class called 'PlayerHealth' and call it ph. Then we're going to check if ph is not equal to (!=) null, and if it's not then we're going to do something with it. Of course, if it is then we can handle it in the else statement.

Now, of course you could just keep looking for it if we don't find it the first time, but if we haven't found it through the means above then chances are that it doesn't exist on the GameObject, and that something is wrong because, by design, we're going to have it there.

Another way to find objects is to use the singleton pattern, which you can read more about here.

avatar image
0

Answer by KojiUnity · Jul 16, 2013 at 02:16 AM

Probably you've already solved your problem. And I was having this same problem just a few minutes ago (using the same tutorials). In my case it was because the script for the class PlayerHealth.cs was not directly on the Player object it was inside Graphics which is inside de Player object I just moved the PlayerHealth.cs script directly to the Player object and the error did no repeat.

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

13 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Anyone Else wanna take a wack at the question ? Need help fixing a script error... 5 Answers

Object reference not set to an instance of an object? 1 Answer

NullReference Problem with pragma strict 1 Answer

How can i fix this weird error 2 Answers

Need a hand using array.Length in a C# editor script 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges