Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by Omer.Hussain · Mar 03, 2014 at 03:53 PM · booleanif-statementsoncollisionenterpower-up

Something wrong with if else conditions...

Hi ! in my code i am creating a shield power up ... what i want when i collide(collect) RollerShoes powerup, then in my script OnCollitionEnter with Hardle my first block turns false if (rollerShoes== false); and second turns true if (rollerShoes==true), but whats happening OnCollition it executes both of the block... i don't where is the problim :/ here is the code #pragma strict

     var powerUpSound: AudioClip; 
     var rollerShoes: boolean= false; //this is for the rollerShoes power up,when true power up is on
     
     GetComponent(forwardmove);
     GetComponent(Timer);
     GetComponent(MagnetPwup);
     GetComponent(PowerRun);
     GetComponent(TouchJump);
      
     function OnCollisionEnter(player: Collision)
     {
     //////////////Hardle////////////////
             if(player.gameObject.tag=="Hardle")
         {
             if (rollerShoes== false); // for roller shoes power up
             {
             print("rollerShoes is On");
             Application.LoadLevel(0);
 //            Timer.timer=false;
 //            forwardmove.flag1= false;
 //            MagnetPwup.magnet= false;
 //            PowerRun.shield=false;
 //            TouchJump.flag=false;
 //            TouchMovement.flag=false;
             }
 //        }
              if (rollerShoes==true)
             {
             Destroy(player.gameObject);
             print("destroy");
             yield WaitForSeconds(2);
             rollerShoes=false;
             }
         }
         else if(player.gameObject.tag=="Magnet")
         {
             audio.PlayOneShot(powerUpSound);
             Destroy(player.gameObject);
             MagnetPwup.magnet= true;
             yield WaitForSeconds(12);
             MagnetPwup.magnet= false;
         
         }
         
         else if(player.gameObject.tag=="PowerShield")
         {
             audio.PlayOneShot(powerUpSound);
             Destroy(player.gameObject);
             PowerRun.shield= true;
     //        Time.timeScale=2.0;
             yield WaitForSeconds(12);
             Time.timeScale=1.0;        
             PowerRun.shield= false;
         }    
         else if (player.gameObject.tag=="RollerShoes")
         {
             Destroy(player.gameObject);
             rollerShoes=true;
             print("its true");
         }
     }
Comment
Add comment · Show 2
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image poncho · Mar 03, 2014 at 03:59 PM 0
Share

i recommend some logic examples to train your logic, also the easiest would be just remove every else, since your conditions are exclusive, they only respond to 1 value, that or a switch

avatar image Omer.Hussain · Mar 04, 2014 at 06:39 AM 0
Share

i know i can use the switch condition either ... i will prefer if you rather put the answer not the recommendations... in my first condition Hardle i want to put inside 2 more conditions.... and rest of the else if is for the collision function ...everything is working well except just the first block of code in which i am putting two conditions... so i dont need to change all of my code ...

1 Reply

· Add your reply
  • Sort: 
avatar image
1
Best Answer

Answer by EvilWarren · Mar 03, 2014 at 03:58 PM

 if (rollerShoes== false);

Drop the semi colon ; at the end of this line. The scope after this is not covered by your if statement because the semi colon terminates it, so it will execute regardless if the condition is true or false.

Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Omer.Hussain · Mar 04, 2014 at 06:44 AM 0
Share

ahhhhhhhh i couldn't notice that .... i put ";" there ... lolx ... it works after removing .. Gracias :') ..

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

22 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

A node in a childnode? 1 Answer

Coroutines and if statements 1 Answer

Both IF statements in a function are run and their conditions are ignored. 4 Answers

Changing Missile Speed 1 Answer

How to activate a panel by a toggle using a script? 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges