Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by MileSplit · Jan 03, 2013 at 09:56 PM · javascriptif-statementsnoobquick

(NOOB Q) Whats wrong with my script? Two if's?

edit(moved from answer)

Wow thats embarrassing :( I posted the wrong code :(

 #pragma strict
 
 function Start () {
 
 }
 var torch: boolean = false;
 var torchGo: GameObject;
 function Update () 
 {
     {
     if (Input.GetKeyUp("t")&&(torch == false))
     light.range = 25;
     torch = true;
     }
 
     {
     if (Input.GetKeyUp("t")&&(torch == true))
     light.range = 0;
     torch = false;
     }
 }

Im trying to make it so that when you press t it turns the torch on/off. Thanks for the fast response, you guys are awesome! :)

Comment
Add comment · Show 1
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image reptilebeats · Jan 03, 2013 at 10:05 PM 0
Share

brackets in wrong place

3 Replies

· Add your reply
  • Sort: 
avatar image
1
Best Answer

Answer by ExTheSea · Jan 03, 2013 at 10:00 PM

So you should do it kinda like this:

     var torch: boolean = false;
     var torchGo: GameObject;
     function Update () 
     {
 
         if (Input.GetKeyUp("t")&&(torch == false)){
         light.range = 25;
         torch = true;
         }
         else if (Input.GetKeyUp("t")&&(torch == true)){
         light.range = 0;
         torch = false;
         }
 
     }
 

or:

         var torch: boolean = false;
         var torchGo: GameObject;
         function Update () 
         {
     
             if (Input.GetKeyUp("t"){
                 if(torch == false)){
                    light.range = 25;
                    torch = true;
                 }
                 else{
                    light.range = 0;
                    torch = false;
                 }
             }
     
         }
Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image
2

Answer by Piflik · Jan 03, 2013 at 10:57 PM

You need to make the second if into an else if, or they will always be executed both.

Also your brackets are wrong...this is how an if statement should look like:

 if(something) {
     //do something
 }
Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image
2

Answer by Eric5h5 · Jan 03, 2013 at 11:24 PM

Should use the KeyCode enum rather than strings. Also it would be better to disable the light rather than setting the range to 0.

 function Update () {
     if (Input.GetKeyUp (KeyCode.T)) {
         light.enabled = !light.enabled;
     }
 }
Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

11 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

flying should only be possible while fuel 0 < but it continues so long as space is held 2 Answers

If/else statements working one way, and not the other 0 Answers

Not updating when script value is changed by an editor script 1 Answer

Audio help. 1 Answer

Daikon Forge change dfLabel text 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges