- Home /
List<> Other elements problems
using UnityEngine;
using System.Collections;
[System.Serializable]
public class pl {
public string name;
public int hp,maxhp;
public int attack;
}
using UnityEngine;
using System.Collections;
using System.Collections.Generic;
public class player : MonoBehaviour {
public pl[] pl;
public List<pl> pll;
void Update(){
}
void OnGUI(){
if(GUILayout.Button("TIKLA")){
pll.Add(pl[0]);
}
}
}
Sorry for very bad english :( When I add list same item. When I change the name of the last item Change is happening as I have all of the same item I want to be independent of the items I need my monsters list.
Answer by Lockstep · Feb 16, 2014 at 10:12 AM
First of all: Change the names of your classes to something meaningfull. In two weeks you probably won't know which was pll and which was pl. Besides you have given the name pl twice. Once for the class and once for an array of that class. Don't do this! I rename the pl class to Monster to avoid confusion.
When you add an element to your list twice, it is still the same object. Both list places refer to the same object. Thus it is only naturally if manupulating an object from one list spot will change what you get if you look up the very same object from another list spot.
The solution is to make a clone of you object.
Cloning is something highly nontrivial. You always have to consider if you want to create a new instance of a variable or get a reference. Here is some usefull information about cloning for further reading.
In your case you can do this: Add a clone constructor to your custom class. It only uses a string and some ints so this will do. If you use other classes like the Transform class in your custom class, you should read the link above.
Add this to your Monster class
public Monster (Monster cloneMe){
this.name = cloneMe.name;
//etc
}
And then in your player class instead of the pll.Add:
Monster newMonster = new Monster(pl[0]);
pll.Add(newMonster);
Your answer
Follow this Question
Related Questions
Removing Missing Objects From A List 1 Answer
A node in a childnode? 1 Answer
Finding enemies from a list script 1 Answer
bool[] to bool list 1 Answer
Get First Object In List 2 Answers