Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by Arcoss · May 21, 2014 at 06:46 PM · c#lightingbool

Making a light turn on and off with the same button

This is what I tried so far, the first function works, the second doesn't

 using UnityEngine;
 using System.Collections;
 
 public class Flashlight_Script : MonoBehaviour {
     bool lightbutto=true;
     public Light flashlight;
 
 
     void FixedUpdate () {
         if(Input.GetKey(KeyCode.R)&&(flashlight.enabled=true)){
             flashlight.enabled=false;
         }
         if(Input.GetKey(KeyCode.R)&&(flashlight.enabled=false)){
             flashlight.enabled=true;
         }
     }
 }
Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
1

Answer by The_Magical_Kiwi · May 21, 2014 at 07:24 PM

When you say first and second function do you mean this?

  if(Input.GetKey(KeyCode.R)&&(flashlight.enabled=true)){
     flashlight.enabled=false;
  }
  if(Input.GetKey(KeyCode.R)&&(flashlight.enabled=false)){
     flashlight.enabled=true;
  }

They aren't functions, they are if statements. This is a function.

  void FixedUpdate () {
        if(Input.GetKey(KeyCode.R)&&(flashlight.enabled=true)){
          flashlight.enabled=false;
        }
        if(Input.GetKey(KeyCode.R)&&(flashlight.enabled=false)){
          flashlight.enabled=true;
        }
     }

Your immediate problem is as follows:

 if(Input.GetKey(KeyCode.R)&&(flashlight.enabled=true)){

If you want to compare something to something else you need to use "==" not "=" try

 if(Input.GetKey(KeyCode.R)&&(flashlight.enabled==true)){

and

 if(Input.GetKey(KeyCode.R)&&(flashlight.enabled==false)){

once you have done that you'll probably find that your light flickers on and off. This is because you have used

Input.GetKey(KeyCode.R)

What this does is return true if a key is held down. What you want is for the torch to come on/go off when ever the key is pressed down initially or when the key is released. Try

Input.GetKeyUp(KeyCode.R)

Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image tw1st3d · May 21, 2014 at 07:27 PM 1
Share

For those who do not know, the reason you need to use == ins$$anonymous$$d of = is, = sets the variable you're checking to the comparison, and == will actually compare them. === is used for an indentical comparison. $$anonymous$$G. if(true === true)

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

23 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Why has a script I created altered every instance of an object? 2 Answers

How do I disable one button out of multiple buttons without spamming declaration? 1 Answer

Distribute terrain in zones 3 Answers

Multiple Cars not working 1 Answer

The name 'Joystick' does not denote a valid type ('not found') 2 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges