Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by NutellaDaddy · Jan 16, 2014 at 04:14 AM · c#

Health script not working, why?

I have enemyDamage defined in another script so why wont this work? Help please!

using UnityEngine; using System.Collections;

 public class PlayerHealth : MonoBehaviour {
 
     public int playerHealth = 100;
     bool dead = false;
 
 
     void OnColliderHit() 
     {
         if (gamobjectWithTag ("Enemy")) 
         {
             playerHealth - enemyDamage;
 
         }
     }
     void Update()
     {
         if (playerHealth <= 0)
             dead == true;
         if(dead == true)
         {
             Application.LoadLevel(Application.LoadedLevel);
         }
     }
 }
 
Comment
Add comment · Show 3
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Quillicit · Jan 16, 2014 at 06:04 AM 0
Share

I see a couple of problems here.

First, replace the OnColliderHit() function with:

 OnCollisionEnter(Collider collider){
     if(collider.tag == "Enemy")
         playerHealth -= enemyDamage; 
 }

Second, at link 18 you want dead = true. The == is a comparison, so it won't change the value.

avatar image fafase · Jan 16, 2014 at 06:08 AM 0
Share

Also, where is enemyDamage from?

avatar image Quillicit · Jan 16, 2014 at 06:12 AM 0
Share

That too! The script that contains the enemyDamage information needs to be referenced here.

1 Reply

· Add your reply
  • Sort: 
avatar image
0
Best Answer

Answer by felixpk · Jan 16, 2014 at 02:12 PM

 public class PlayerHealth : MonoBehaviour {
  
     public int playerHealth = 100;
     bool dead = false;
  
  
     void OnCollisionEnter(Collider other) 
     {
        if (other.gameObject.tag == "Enemy") 
        {
          enemyDamage = other.getComponentInChildren<EnemyScript>().damage;
          playerHealth = playerHealth - enemyDamage;
  
        }
     }
     void Update()
     {
        if(playerHealth <= 0){
          dead = true;
          Application.LoadLevel(Application.LoadedLevel);
        }
     }
 }

Then to all Enemy's you attach a script like

 public class EnemyScript : MonoBehavior{
    public int damage = 10;
 }

Try to analyze the code, there are several mistakes you made, but this way it should work.

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

20 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

The name 'Joystick' does not denote a valid type ('not found') 2 Answers

I have never seen a null reference exception like this one! 1 Answer

Can't convert int to bool? 2 Answers

Detecting Collision between Charctor controller and Box Collider 2 Answers

OnGui Button not displaying 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges