Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by ccwiegreff · Jan 15, 2014 at 12:08 AM · javascriptfunction updatetruecentered

=true then =false then back to true

this is in my pause menu to lock the cursor to the center but when i press escape free it for a bit to press option buttons then when i press escape again to lock it to the center again,what arent i doing?

 var SwitchOnSound:AudioClip;
 var SwitchOffSound:AudioClip;
 private var Off : boolean = false;
 private var On : boolean = true;
 
 function Start () {
     Screen.lockCursor = true;
 }
 
 function Update()
 {
     if(Screen.lockCursor)
     {
        if(Off)
        {
          if(Input.GetKeyDown(KeyCode.Escape))
          {
           On = true;
           Off = false;
           AudioSource.PlayClipAtPoint(SwitchOnSound, transform.position);
          }
        }
        else
        {
          if(On)
          {
           if(Input.GetKeyDown(KeyCode.Escape))
           {
               On = false;
               Off = true;
               AudioSource.PlayClipAtPoint(SwitchOffSound, transform.position);
           }
          }
        }
     }
 }
Comment
Add comment · Show 1
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Josh707 · Jan 15, 2014 at 12:33 AM 0
Share

The first thing I notice is the entire block of if statements only runs if the cursor is locked. You also might as well just use one boolean with a name such as 'is_enabled', there is no point having two booleans to change one other.

 private var lock_cursor : boolean = false;
 
 function Update(){
     Screen.lockCursor = lock_cursor;
 
     if(Input.Get$$anonymous$$eyDown("escape")){
         AudioSource.PlayClipAtPoint((lock_cursor) ? OffSound : OnSound, transform.position);
         lock_cursor = !lock_cursor;
     }
 }

Just in case you don't know the ternary operator will evaluate what's in the parenthesis and return the first value if it is true and the second if it is false, in this case a simple way of playing the two toggle sounds without having if statements.

1 Reply

· Add your reply
  • Sort: 
avatar image
1
Best Answer

Answer by Olgo · Jan 15, 2014 at 12:34 AM

Seems to me you aren't toggling your Screen.lockCursor at any point, it always == true;

I don't know what your entire project entails and what you use On and Off for, but seems to me you could really simplify this.

 if(Input.GetKeyDown(Keycode.Escape)){
   Screen.lockCursor = !Screen.lockCursor
   if(Screen.lockCursor)
     AudioSource.PlayClipAtPoint(SwitchOffSound, transform.position);
   else
     AudioSource.PlayClipAtPoint(SwitchOnSound, transform.position);
 }
Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

20 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

scripting is not working for words "true" & "false" 1 Answer

Fixed error but error still shows in the console 2 Answers

Could someone fix this : It says expressions must only be executed ofr their side-effects 1 Answer

Copy rotation values in between objects. 1 Answer

Setting Scroll View Width GUILayout 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges