Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by MrReynevan2 · Jan 11, 2014 at 05:07 PM · functions

Use of unassigned local variable "Converted"

Hey. I have a problem with my function.

Here's the code:


        string ConvertDifficulty(int difficulty) {
            string Converted;
            switch (difficulty) {
            case 1:
                Converted = "Easy";
                break;
            case 2:
                Converted = "Medium";
                break;
            case 3:
                Converted = "Hard";
                break;
            }
            return Converted;
        }

And I got an error described above. Why is it happening? Can I declare new variables inside functions? I always thought i can... What's wrong with this function?

Comment
Add comment · Show 1
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image robertbu · Jan 11, 2014 at 05:17 PM 1
Share

Doing as @tanoshimi says or adding a 'default' clause to your 'switch' statement will fix the problem. To understand the issue, what value would be returned if you passed in some value other than 1, 2, or 3 to your ConvertDifficulity() method? Undefined.

3 Replies

· Add your reply
  • Sort: 
avatar image
1

Answer by tanoshimi · Jan 11, 2014 at 05:13 PM

Initialise the string to some value. Replace:

 string Converted;

with:

 string Converted = "";

Otherwise there's a chance that your function will fall through the entire switch() statement without Converted ever being assigned a value (if difficulty is some value other than 1,2, or 3), which is what the error message is complaining about.

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image
0

Answer by MrReynevan2 · Jan 12, 2014 at 07:39 PM

I thought so, thanks alot.

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image
0

Answer by KellyThomas · Jan 11, 2014 at 05:18 PM

 string ConvertDifficulty(int difficulty) {
     string Converted;
     switch (difficulty) {
         case 1:  
             Converted = "Easy";
             break;
         case 2:
             Converted = "Medium";
             break;
         case 3:
             Converted = "Hard";
             break;
     }
     return Converted;  
 }

If you consider the code above not all code paths assign a value to Converted, as an example if difficulty is set to 4 then none of the cases in your switch will apply.

The easy solution is to initialize converted with a value on the same line it's declaration:

     string Converted = "";
Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

20 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

The name 'Joystick' does not denote a valid type ('not found') 2 Answers

Decrease a value during a certain amount of time based on another value 1 Answer

Weird Code Error Message 2 Answers

How to import the object from server to unity 2 Answers

Can someone help me fix my Javascript for Flickering Light? 6 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges