Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by PictonicStudio · Nov 06, 2013 at 01:18 AM · androidpositionjoystickstime.time

Rate of fire c# with joystick.

Im trying to use the right joystick in my android game to fire plasma bolts automatically.

My question is why this block of code works: if (Input.GetKey(KeyCode.Space) && Time.time >= nextFire) { nextFire = Time.time + fireRate; FireBullet(); }

When this doesnt:

if (RightJoyStick.position.x != 0 || RightJoyStick.position.y != 0 && Time.time >= nextFire)
{
   nextFire = Time.time + fireRate;
   FireBullet();
}

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
1
Best Answer

Answer by rutter · Nov 06, 2013 at 01:27 AM

Because && has a higher precedence than || in .NET

Given some booleans a, b and c, this expression:

 if (a || b && c)

Is actually closer to this:

 if (a || (b && c))

When you seem to mean this:

 if ((a || b) && c)

Whenever you rely on a particular grouping of logical operators, it's usually a good idea to specify that yourself.

You could provide parens:

 if ((RightJoyStick.position.x != 0 || RightJoyStick.position.y != 0) && Time.time >= nextFire) {
     ...
 }

Or use temporary variables:

 bool joystickMoved = RightJoyStick.position.x != 0 || RightJoyStick.position.y != 0;
 bool canFire = Time.time >= nextFireTime;
 if (joystickMoved && canFire) {
     ...
 }
Comment
Add comment · Show 3 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image PictonicStudio · Nov 06, 2013 at 01:32 AM 0
Share

Thanks. I though I had tried that before but when I did it this time it worked.

avatar image PictonicStudio · Nov 06, 2013 at 01:32 AM 0
Share

$$anonymous$$ind of feel dumb, lol. This is coding 101

avatar image rutter · Nov 06, 2013 at 03:12 AM 0
Share

Every language does it juuuust a bit differently. Habits that worked in one environment might not work in another. Coding is harsh!

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

16 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Multiple Mobile Single Stick Controllers (Cross Platform Input Package) 0 Answers

Unity3D Screensize remain same Position and Scale 0 Answers

I don't want the standard mobile asset Joystick.js script resets the position of joystick when i raise my finger from touch screen of smartphone 0 Answers

Same button position in all Android devices 2 Answers

iPhone Droid Input.GetTouch(i).position 4 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges