Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by JJNCreator · Jul 01, 2012 at 08:38 PM · c#enemyragdolltarget

Targeting problem

hi guys. i made a targeting script (c#) and a ragdoll enemy. the targeting works fine, but when i kill the enemy and the ragdoll starts, i cant target the other enemies. here's the targeting script:

     using UnityEngine;
 using System.Collections;
 using System.Collections.Generic;
 
 public class Targeting : MonoBehaviour {
     public List<Transform> targets;
     public Transform selectedTarget;
 
 private Transform myTransform;

 // Use this for initialization
 void Start () {
     targets = new List<Transform>();
     selectedTarget = null;
     myTransform = transform;
     
     AddAllEnemies();
 
 }
 
 public void AddAllEnemies()
 {
     GameObject[] go = GameObject.FindGameObjectsWithTag("Enemy");
     
     foreach(GameObject enemy in go)
         AddTarget(enemy.transform);
 }
 
 public void AddTarget(Transform enemy)
 {
     targets.Add(enemy);
 }
 
 
 private void SortTargetsByDistance()
 {
     targets.Sort(delegate(Transform t1, Transform t2) { 
         return Vector3.Distance(t1.position, myTransform.position).CompareTo(Vector3.Distance(t2.position, myTransform.position));
             });
 }
 
 private void TargetEnemy()
 {
     if(selectedTarget == null)
     {
         SortTargetsByDistance();
         selectedTarget = targets[0];
     }
     else
     {
         int index = targets.IndexOf(selectedTarget);
         
         if(index < targets.Count - 1)
         {
             index++;
         }
         else
         {
             index = 0;
         }
         DeselectTarget();
         selectedTarget = targets[index];
     }
     SelectTarget();
 
 }
 
 private void SelectTarget()
 {
     selectedTarget.renderer.material.color = Color.green;

 }
 
 private void DeselectTarget()
 {
     selectedTarget.renderer.material.color = Color.red;
     selectedTarget = null;
 }
 
 // Update is called once per frame
 void Update () {
     if(Input.GetKeyDown(KeyCode.Tab))
     {
         TargetEnemy();
     }
 
 }

}

do u have any suggestions? many thanks.

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
0
Best Answer

Answer by whydoidoit · Jul 01, 2012 at 08:46 PM

You don't appear to be removing any enemies from the array - so I guess the one that is a ragdoll is the closest. Also use Linq! It makes code so much easier to read. Rewritten below:

 using System.Linq;
     using UnityEngine;
 using System.Collections;
 using System.Collections.Generic;
 
 public class Targeting : MonoBehaviour {
     public List<Transform> targets;
     public Transform selectedTarget;
 private Transform myTransform;
 
 // Use this for initialization
 void Start () {
     selectedTarget = null;
     myTransform = transform;
     targets = GameObject.FindGameObjectsWithTag("Enemy").Select(g=>g.transform).ToList();    
 }
 
 private void TargetEnemy()
 {
     if(selectedTarget == null)
     {

        selectedTarget = targets.OrderBy(t=>Vector3.Distance(t.position, myTransform.position).FirstOrDefault();
     }
     else
     {
        int index = targets.IndexOf(selectedTarget);
 
        if(index < targets.Count - 1)
        {
          index++;
        }
        else
        {
          index = 0;
        }
        DeselectTarget();
        selectedTarget = targets[index];
     }
     if(selectedTarget != null)
         SelectTarget();
 
 }
 
 private void SelectTarget()
 {
     selectedTarget.renderer.material.color = Color.green;
 
 }

 public void KillSelectedTarget()
 {
        targets.Remove(selectedTarget);
        DeselectTarget();
 }
 
 private void DeselectTarget()
 {
     selectedTarget.renderer.material.color = Color.red;
     selectedTarget = null;
 }
 
 // Update is called once per frame
 void Update () {
     if(Input.GetKeyDown(KeyCode.Tab))
     {
        TargetEnemy();
     }
 
 }

   

 }
Comment
Add comment · Show 4 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image JJNCreator · Jul 01, 2012 at 09:00 PM 0
Share

didnt seem to work. i have this script attached to my player :

var deadReplacement : Transform; var aliveObject : GameObject;

function replaceWithRagdoll() { // Destroy ourselves Destroy(aliveObject);

 if(Destroy)
 {
     Destroy(aliveObject);
 }

 // Replace ourselves with the dead body
 if (deadReplacement) 
 {
     var deadBody = Instantiate(deadReplacement.transform, transform.position, transform.rotation);
     gameObject.Find("Bip001_Pelvis").rigidbody.AddForce(-transform.forward * 5);
 }
 
 
 

};

its a javascript that replaces the enemy with the ragdoll. could this be messing up the target script?

avatar image whydoidoit · Jul 01, 2012 at 09:02 PM 0
Share

Did you call the $$anonymous$$illSelectedTarget function I wrote in the code above somewhere? It should be the first thing in the replaceWithRagdoll function.

avatar image JJNCreator · Jul 01, 2012 at 09:06 PM 0
Share

works okay now. thanks :D

avatar image whydoidoit · Jul 01, 2012 at 09:11 PM 0
Share

You are welcome :)

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

5 People are following this question.

avatar image avatar image avatar image avatar image avatar image

Related Questions

Targetting Script Help 1 Answer

C# AI, Enemy is flying at me when I jump. 2 Answers

How do you create a "collect" objection that corresponds with the enemy behavior in C#? 1 Answer

Distribute terrain in zones 3 Answers

Enemy Targetting Help 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges