Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by JoshMBeyer · Jan 29, 2014 at 10:26 PM · componentget

Why wont this work? (I've done similar 1000 times fine)

I've done this get component stuff 1000 times and its worked just fine, but its been a while so I don't remember if this is right. I would like it to work without making a public variable for the player but that wasn't working either. I am trying to access the player's script NPCDropper when the health equals Zero. and set the boolean to true.

public class EnemyHealth : MonoBehaviour {

     public int curHP;
     public int maxHP;
     public GameObject player;
 
     void Start () 
     {
         curHP = maxHP;
     }
 
     void Update () 
     {
         if(curHP <= 0)
         {
             var npcD = player.GetComponent<NPCDropper>();
             npcD.weShouldDrop = true;
         }
     }
 }
Comment
Add comment · Show 1
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image TonyLi · Jan 30, 2014 at 01:02 AM 0
Share

What's not working? Are you getting a NullReferenceException?

A few things to note:

  1. You can use "var" in C#. So you're fine there.

  2. Since you're not going to be calling GetComponent() every frame, it's fine to declare it in Update.

  3. When you post a question or answer, there's a "101/010" button. Click this before entering code to format it properly.

Whenever you call GetComponent(), you should almost always check that the return value is valid (not null). You can skip this if you use the RequireComponent directive. For example:

 [RequireComponent(typeof(NPCDropper))]
 public class EnemyHealth : $$anonymous$$onoBehaviour {
    ...
 }

In this case, you're guaranteed that it will have an NPCDropper, so GetComponent() should never return null.

1 Reply

· Add your reply
  • Sort: 
avatar image
1
Best Answer

Answer by programmrzinc · Jan 29, 2014 at 10:28 PM

You are mixing unityscript and C. you are using var to declare a variable.

 public int curHP;
     public int maxHP;
     public GameObject player;
  
     void Start () 
     {
         curHP = maxHP;
     }
  
     void Update () 
     {
         if(curHP <= 0)
         {
             NPCDropper npcD = player.GetComponent<NPCDropper>();
             npcD.weShouldDrop = true;
         }
     }
 }
Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image clunk47 · Feb 06, 2014 at 10:48 PM 0
Share

http://msdn.microsoft.com/en-us/library/bb383973.aspx

Just to clarify, you can use var in c#. Good answer though.

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

21 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Yet another NullReferenceException question. 2 Answers

Script for getting in and out of a tank 2 Answers

Problems deactivating a script. 1 Answer

How to get a value from an array within another script. 1 Answer

BCE0019: 'enabled' is not a member of 'UnityEngine.Component'. ??? 2 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges