Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by CrilleStyles · May 27, 2014 at 04:18 PM · javascripterrorhealth

Health not counting down?

My health is not counting down in this script:

 #pragma strict
 
 var tex1 : Texture;
 var tex2 : Texture;
 var tex3 : Texture;
 var tex4 : Texture;
 var tex5 : Texture;
 
 var health : float = 100.0;
 
 private var maxHealth : float = 100.0;
 private var enterCollider : boolean = false;
 
 //Damage Collider
 function OnTriggerEnter (Col : Collider)
 {
     if(Col.gameObject.tag == "Enemy")
     {
         enterCollider = true;
         Debug.Log("Is inside collider");
     }
 }
 
 function OnTriggerExit (Col : Collider)
 {
     if(Col.gameObject.tag == "Enemy")
     {
         enterCollider = false;
     }
 }
 
 function Update ()
 {
     //Health countdown whilst in the damage collider
     if(health > 0 && enterCollider == true)
     {
         health -= Time.deltaTime * 20;
     }
     if(health >= 0)
     {
     yield (WaitForSeconds (1));
     Application.LoadLevel("Deade");
     }
     
     //Normal health regeneration
     if(health >= 0 && enterCollider == false)
     {
         health += Time.deltaTime * 5;
     }
     
     //When health reaches 100, set to maxHealth
     if(health > maxHealth)
     {
         health = maxHealth;
     }
 }
 
 function OnGUI ()
 {
     if (health <= 70)
     {
         GUI.DrawTexture(Rect(0,0, Screen.width, Screen.height), tex1);
     }
     
         if (health <= 45)
     {
         GUI.DrawTexture(Rect(0,0, Screen.width, Screen.height), tex2);
     }
     
         if (health <= 25)
     {
         GUI.DrawTexture(Rect(0,0, Screen.width, Screen.height), tex3);
     }
     
         if (health <= 10)
     {
         GUI.DrawTexture(Rect(0,0, Screen.width, Screen.height), tex4);
     }
     if(health <= 0)
     {
      GUI.DrawTexture(Rect(0,0, Screen.width, Screen.height), tex5);
 }
 }
 
 
Comment
Add comment · Show 4
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image siaran · May 27, 2014 at 04:45 PM 0
Share

are OnTriggerExit/Enter, uh... triggering? If not check if your tags are set correctly and if you have rigidbodies attached.

avatar image CrilleStyles · May 27, 2014 at 05:17 PM 0
Share

They are. Something happend around the yield area

avatar image siaran · May 27, 2014 at 05:25 PM 0
Share

you have

 if (health >= 0) 
 {
 yield (WaitForSeconds (1));
 Application.LoadLevel("Deade");
 }

I'm fairly sure that should be

 if(health <= 0)

avatar image PouletFrit · May 27, 2014 at 05:27 PM 0
Share

if(health >= 0) { yield (WaitForSeconds (1)); Application.LoadLevel("Deade"); }

seems weird to me... Your game will keep reloading this scene as long as ur health is higher than 0... Is that the desired behaviour? and also u can't yield in Update function... you would need to start a coroutine from it which would yield in it

1 Reply

· Add your reply
  • Sort: 
avatar image
0
Best Answer Wiki

Answer by TKS_Keeper · May 27, 2014 at 08:55 PM

You have a few problems here. I'm supplying some cleaned up code with some (potential) fixes here.

Your key issues were:

  • Misuse of yield within a noncoroutine.

  • Not using else if or else logical blocks

Coroutines are tricky but powerful tools. They require explicitly being started through the MonoBehaviour.StartCoroutine method. See for details on this. http://docs.unity3d.com/ScriptReference/MonoBehaviour.StartCoroutine.html

They next issue was that because many of the logical blocks could activate together there was a lot of unexpected behavior. This was especially bad in the OnGui method.

I'd suggest becoming familiar with using the debugger, and stepping through your code if you have problems like this. As has been pointed out by others, there were conditionals which were probably not evaluating as intended in several places and without the 'else if' and 'else' usage your code was executing a lot of unnecessary and potentially disruptive code. (Rule of thumb, if one thing should happen and not the others, then 'else' and 'else if' are your friends)

 # pragma strict
 
 var tex1 : Texture;
 var tex2 : Texture;
 var tex3 : Texture;
 var tex4 : Texture;
 var tex5 : Texture;
 
 var health : float = 100.0;
 
 private var dead : bool = false;
 private var maxHealth : float = 100.0;
 private var enterCollider : boolean = false;
 
 var damagePerSecondOnContact : float = 20;
 var healthRegeneratedPerSecond : float = 5;
 
 
 //Damage Collider
 function OnTriggerEnter(Col : Collider) {
     if (Col.gameObject.tag == "Enemy") {
         enterCollider = true;
         Debug.Log("Is inside collider");
     }
 }
 
 function OnTriggerExit(Col : Collider) {
     if (Col.gameObject.tag == "Enemy") {
         enterCollider = false;
     }
 }
 
 function Update() {
 
     if(dead){
         health = 0;
         return;
     }
     
     //check for health exceeding maxHealth and correct if needed
     if (health > maxHealth) {
         health = maxHealth;
     }
     
     if (health > 0) {
         //We are alive! Check if we should heal or take damage
         if(enterCollider == true){
             //take damage
             health -= Time.deltaTime * damagePerSecondOnContact;
             Debug.Log("Was damaged to " + health);
         }
         else{
             //heal (a heal delay might be good, we may be regenerating faster than collisions can cause damage)
             health += Time.deltaTime * healthRegeneratedPerSecond;
             Debug.Log("Was healed to " + health);
         }
     }
     else if (health <= 0) {
         StartCoroutine(OnHealthZero()); //THIS WAS WHAT WAS MISSING
     }
 }
 
 function OnGUI() {
     if (health <= 0 || dead) {
         GUI.DrawTexture(Rect(0, 0, Screen.width, Screen.height), tex5);
     }
     else if (health <= 70) {
         GUI.DrawTexture(Rect(0, 0, Screen.width, Screen.height), tex1);
     }
     else if (health <= 45) {
         GUI.DrawTexture(Rect(0, 0, Screen.width, Screen.height), tex2);
     }
     else if (health <= 25) {
         GUI.DrawTexture(Rect(0, 0, Screen.width, Screen.height), tex3);
     }
     else if (health <= 10) {
         GUI.DrawTexture(Rect(0, 0, Screen.width, Screen.height), tex4);
     }
 }
 
 /** 
  *  Coroutine function which runs the death sequence.
  *  @see http://docs.unity3d.com/ScriptReference/MonoBehaviour.StartCoroutine.html
  */
 function OnHealthZero(){
     //we indicate that the player died IMMEDIATELY so as to stop bad updates
     Debug.Log("Is dead now");
     dead = true;
     yield(WaitForSeconds(1));
     Application.LoadLevel("Deade");
 }
Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

23 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

error javasript 1 Answer

How do I change the text of a gui image text 1 Answer

What's wrong with eval()? 1 Answer

NullReferenceException: Object reference not set to an instance of an object 1 Answer

An instance of type (Script) is required to access non static member (Script) 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges