Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by loondas · May 17, 2014 at 11:19 PM · raycastcollidernullreferenceexceptioninstancegrab

null new collider for raycast grabbing

I am trying to create a script that grabs an object when you press 'g'. I think the code I wrote should work, but I get "NullReferenceException: Object reference not set to an instance of an object Cameragrab.Update () (at Assets/Cameragrab.cs:24)" when I try to grab an object.

Here's the code:

 using UnityEngine;
 using System.Collections;
 
 public class Cameragrab : MonoBehaviour
 {
         // Use this for initialization
         void Start ()
         {
     
         }
     
         // Update is called once per frame
         void Update ()
         {
         GameObject held = new GameObject();
                 if (Input.GetKey ("g")) {
                         RaycastHit hit = new RaycastHit();
 
                         if (Physics.Raycast (transform.position, transform.forward, 5f)) {
                                 Debug.Log ("Touching");
                 if(hit.collider == null){
                     Debug.Log("Here");
                 }
                                 held = hit.collider.gameObject;
 
                                 hit.collider.gameObject.transform.parent = transform;
                                 hit.collider.gameObject.transform.position = transform.position - transform.forward;
                         }
                 } else if (held != null) {
                         held.transform.parent = null;
                         held = null;
                 }
         }
 }



It seems when I create the new hit raycast, it is null, as I receive the "Here" in my debug log when I press "g". Is this the problem? If not, what is? If it is, how do I fix it?

Comment
Add comment · Show 4
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Jeff-Kesselman · May 17, 2014 at 11:19 PM 0
Share

It is very hard to help you because the error you gave us makes reference to a line number and you didn't give us the complete script.

Please give us the complete script, and PLEASE format it so it is all in the code box. Then we might be able to help you more...

avatar image Jeff-Kesselman · May 17, 2014 at 11:30 PM 0
Share

exactly! Thanks for making it readable. It made it much easier to see the issue :)

avatar image loondas · May 17, 2014 at 11:32 PM 1
Share

Thank you $$anonymous$$rFijiWiji. It worked! Now I just need to fine tune it.

avatar image loondas · May 17, 2014 at 11:37 PM 0
Share

And thank you jeff. I am very new, and trying to figure the system out.

1 Reply

· Add your reply
  • Sort: 
avatar image
1

Answer by MrFijiWiji · May 17, 2014 at 11:28 PM

as far as i can tell, hit is never assigned to, so will always be null. Try changing:

 if (Physics.Raycast (transform.position, transform.forward, 5f))

to:

 if (Physics.Raycast (transform.position, transform.forward, out hit, 5f))

also, remove the new RaycastHit(); declaration, as when you have the g button held down, it will set it to null every frame. Same goes for the held gameobject variable in update. Remove the new GameObject(); declaration otherwise it will be set to null every frame. Instead, set it after your class name so that you have it cached after pressing g.

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

22 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Finding a RaycastHit tag (Null Reference Exception) 2 Answers

move object over another object normals 1 Answer

Raycast causes game to crash when shooting up 1 Answer

Issue with raycast hit 1 Answer

Please help me with Raycast 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges