Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by Dreave · Dec 22, 2011 at 08:22 PM · error

Script Error!!

I really do not understand what is wrong with my script, I have an error saying expecting ( , found Shoot. But I dont have a clue what I have done wrong can anyone help me?

 function Update (){

if(Input.GetButtonDown("Fire1")){

 Shoot();

 }

 

var shootSound : AudioClip;

var bloodPrefab : Transform;

var sparksPrefab : Transform;

var range = 500;

function Shoot(){

if(Physics.Raycast(transform.position, transform.forward, hit, range)){

 var rot = Quaternion.FromToRotation(Vector3.up, hit.normal);



 if(hit.collider.tag == "Enemy"){

     if(bloodPrefab){

         Instantiate(bloodPrefab, hit.point, rot);

     }

         hit.collider.gameObject.SendMessage("ApplyDamage", 25, SendMessageOptions.DontRequireReceiver);

     }else{

     if(sparksPrefab){

         Instantiate(sparksPrefab, hit.point, rot);

         }

     }

 }

}

}

Comment
Add comment · Show 3
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image tatelax · Dec 22, 2011 at 08:53 PM 0
Share

Can you post the line that has the error?

avatar image Dreave · Dec 22, 2011 at 08:58 PM 0
Share

its on line 11 function Shoot() {

avatar image Grady · Dec 22, 2011 at 08:59 PM 0
Share

you have got all your variables inside the Update() function... try moving them to the very top of your script!!!!

1 Reply

· Add your reply
  • Sort: 
avatar image
1
Best Answer

Answer by Grady · Dec 22, 2011 at 09:09 PM

Here you go, I think your error was that you had your curly brackets for closing your Update() function after the Shoot() function, plus I think you had an extra one there in the end as well!!!!!! There were also a couple of errors with the raycast, so I updated that too!!!! I fixed up your code for you and it should work now!!!!! I also indented it, so it is a bit easier to read!

var shootSound : AudioClip; var bloodPrefab : Transform; var sparksPrefab : Transform; var range = 500; var hit : RaycastHit;

function Update (){ if(Input.GetButtonDown("Fire1")){ Shoot(); } }

function Shoot(){ var fwd = transform.TransformDirection (Vector3.forward); if(Physics.Raycast(transform.position, fwd, hit, range)){ var rot = Quaternion.FromToRotation(Vector3.up, hit.normal); if(hit.collider.tag == "Enemy"){ if(bloodPrefab){ Instantiate(bloodPrefab, hit.point, rot); } hit.collider.gameObject.SendMessage("ApplyDamage", 25, SendMessageOptions.DontRequireReceiver); } else{ if(sparksPrefab){ Instantiate(sparksPrefab, hit.point, rot); } } } }

It should work now, but if not, then just post back

Comment
Add comment · Show 2 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Dreave · Dec 22, 2011 at 09:14 PM 0
Share

Thanks for your help, it was driving me crazy.

avatar image Grady · Dec 22, 2011 at 09:21 PM 0
Share

your welcome, I also switched your raycast method around, i'm not sure if it was working for you, but when i put your script into my unity it came up with some errors with the hit variable, so i updated your raycast error at the top of the shoot() function!!!

Glad I could help!

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

6 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Null in GetValidMethodInfo 0 Answers

A node in a childnode? 1 Answer

press play, game objects get deleted, game breaks. 1 Answer

Targetting error please help 0 Answers

Old Script errors messing up a new scene 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges