Question by J1M · Mar 17, 2014 at 02:38 AM · instantiate prefab getcomponent

How to reduce usage of GetComponent()? (instantiate, prefabs)

I'm using the following code to instantiate a prefab:

 GameObject dialog = Instantiate(Prefab.ChooseNameDialog) as GameObject;
 NameScriptController controller = dialog.GetComponent<NameScriptController>();
 controller.Property = propertyValue;

I am concerned about using GetComponent() like this. It looks like bad style. There is no type safety. All I can really do is try to remember to add my script to the prefabs.

In other instances, I've been able to replace GetComponent() calls with public variables of type ScriptName. I would like to find a similar solution for instantiating prefabs.

Add comment · Show 3

Benproductions1 · Mar 17, 2014 at 10:13 AM 2

One GetComponent per Instantiate isn't going to make much of a difference. The biggest killer in performance is your Instantiate. Use an Object pool and you will have to use neither Instantiate not GetComponent.

J1M · Mar 17, 2014 at 10:38 PM 0

This is not a performance question. It is about code maintainability.

karljj1 · Mar 17, 2014 at 11:20 PM 0

You could check if your prefab has the component and add it if not.

 NameScriptController controller = dialog.GetComponent<NameScriptController>() ?? dialog.AddComponent<NameScriptController>();

 controller.Property = propertyValue;

You can also force a GameObject to have an other script using the RequireComponent attribute https://docs.unity3d.com/Documentation/ScriptReference/RequireComponent.html