Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by Vedsten · Nov 11, 2010 at 09:20 PM · crashfunctionint

Unity Crash on Function Run

Hello, can any tell me why this causes unity to crash (before I even get an error msg.)

var pressed : int;

function Update () {

 if (Input.GetMouseButtonDown(0)){
     pressed = 1;
     mouseCheck();
 }

}

function mouseCheck () {

 while (pressed==1){
     if (Input.GetMouseButtonUp(0)){
     pressed=0;
     }
 }

}

-- I've tried commenting out different lines and "while (pressed==1)" seems to be the problem, any input as to why this is happening?

Cheers

Comment
Add comment · Show 1
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image VS48 · Nov 11, 2010 at 09:30 PM 0
Share

Yes -- you set pressed to 1 and then it goes into a loop until the Get$$anonymous$$ouseButtonUp(0) returns true, which most likely won't happen because you killed the CPU already.

2 Replies

· Add your reply
  • Sort: 
avatar image
1
Best Answer

Answer by Gareth Rees · Nov 11, 2010 at 10:02 PM

As the others have said, your function mouseCheck loops forever: it keeps checking to see if the mouse button is up, without letting any other code get a look in, and that includes the code for updating the mouse button status. (So even if you release the mouse button, your code never gets to find out.)

So I suggest making mouseCheck into a coroutine that calls yield to give other code a chance to run:

var pressed = false;

function Update () { if (Input.GetMouseButtonDown(0)) { pressed = true; mouseCheck(); } }

function mouseCheck () { while (pressed) { yield; if (Input.GetMouseButtonUp(0)) { pressed = false; } } }

Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Vedsten · Nov 14, 2010 at 07:15 PM 0
Share

thanks alot! this did the trick beatifuly

avatar image
2

Answer by matyicsapo · Nov 11, 2010 at 09:29 PM

infinite loop, the if in mouseCheck checks the value in the same frame halting program execution

look into Coroutines, Events(OnMouseXXX methods especially), or just put the 2nd if into Update checking for MButtonUp every frame

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

No one has followed this question yet.

Related Questions

The name 'Joystick' does not denote a valid type ('not found') 2 Answers

Setting variables in one script from another. 1 Answer

using non static variable in static function 1 Answer

How to call and run a function from another script on a transform. 0 Answers

communicating between scripts doesnt work 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges