Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by darky · Feb 29, 2012 at 05:08 AM · custom editorundosharedmaterial

How to Undo SharedMaterial set in CustomEditor?

In a CustomEditor I'm creating I am trying to set a few new Materials, but somehow the Undo function doesn't seem to grip when I use SharedMaterial. When I use just Material instead of sharedMaterial, I end up with leaking materials and new Instances that I do not want.

My code goes something like this:

 Undo.RegisterSceneUndo("Assigning Textures");
 
 Renderer[] renderers = user.gameObject.GetComponentsInChildren<Renderer>();
                     
     if(renderers != null)
     {
         foreach(Renderer r in renderers)
         {
             foreach(Material m in r.sharedMaterials)
             {
                 if(m.HasProperty("_MainTex")) m.SetTexture("_MainTex", t);
             }
     }
Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
1
Best Answer

Answer by jspease · Feb 29, 2012 at 05:33 AM

RegisterSceneUndo doesn't work here because the shared material is an asset, which doesn't exist in the scene. So in this case you have to be more specific about which things you want to be able to undo, by using Undo.RegisterUndo, like this:

Renderer[] renderers = user.gameObject.GetComponentsInChildren<Renderer>();

if(renderers != null) { List<Material> materialsToEdit = new List<Material>(); foreach(Renderer r in renderers) { foreach(Material m in r.sharedMaterials) { if(m.HasProperty("_MainTex")) materialsToEdit.Add(m); } }

 Undo.RegisterUndo(materialsToEdit.ToArray(), "Assigning Textures");

 foreach(Material m in materialsToEdit)
     m.SetTexture("_MainTex", t);

}

Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image darky · Feb 29, 2012 at 03:29 PM 0
Share

Thank you, that worked perfectly. I find that it even works nicely in combination with a SceneUndo that I do in the same function for another Operation that I do there before the Texture Assign, so now it Undo's both correctly with just one click. That's a very nice side-effect :)

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

5 People are following this question.

avatar image avatar image avatar image avatar image avatar image

Related Questions

Multiple sharedMaterial(s) 0 Answers

Undo.RegisterFullObjectHierarchyUndo not working 1 Answer

Unity 5.5.1 - Custom editor button Undo query 0 Answers

Custom Editor serializing data in prefab instance. 0 Answers

Undo.Record: Recording variables within array elements 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges