Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by laurienash · Jan 25, 2015 at 03:31 PM · javascriptcoroutinebasic

Stop coroutine not working

Hi - I need a light to be on for 2 seconds and then be set to active = false each time a camera is set to active, but instead the camera starts flashing continuously, I guess because the coroutine is looping?

Do you know what I'm doing wrong?

 var light1 : GameObject;
 var cameraF4N : GameObject;
 
 function Update () {
 
 if(cameraF4N.activeInHierarchy == true) {
 
 StartCoroutine ("spotLightCoroutine");
 
 }
 
 if(cameraF4N.activeInHierarchy == false) {
 
 StopCoroutine ("spotLightCoroutine");
 
 }
 
 }
 
 function spotLightCoroutine () {
 
 while (true) {
 
 light1.active = true;
 
 yield WaitForSeconds (3);
 
 light1.active = false;
 
 yield;
 
 }
 
 }

All the best, Laurien

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
2
Best Answer

Answer by Simon-Larsen · Jan 25, 2015 at 04:10 PM

You should assign your script to the "cameraF4N" gameobject and use the OnEnable and OnDisable functions. The problem is that you're starting a lot of coroutines in the update function, which is called every frame.

 var light1 : GameObject;

 function OnEnable()
 {
     StartCoroutine ("spotLightCoroutine");
 }
 
 function OnDisable()
 {
     StopCoroutine ("spotLightCoroutine");
 }
 
 function spotLightCoroutine ()
 {
     light1.active = true;
     yield WaitForSeconds (3);
     light1.active = false;
 }

If attaching the script to the "cameraF4N" gameobject is not an option, then you could use a bool flag to make sure you only start the coroutine once.

 var isRunning : boolean

 function Update () 
 {
     if(cameraF4N.activeInHierarchy == true && !isRunning) 
     {
         StartCoroutine ("spotLightCoroutine");
     }
     else if(cameraF4N.activeInHierarchy == false) 
     {
         StopCoroutine ("spotLightCoroutine");
         isRunning = false;
     }
 }

 function spotLightCoroutine ()
 {
     isRunning = true;
     light1.active = true;
     yield WaitForSeconds (3);
     light1.active = false;
     isRunning = false;
 }

Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image laurienash · Jan 25, 2015 at 05:20 PM 0
Share

Yay thank you so much!!! (I didn't think of assigning it to the camera ins$$anonymous$$d :/ - that solves a lot of other scripting problems I'm having. How silly) :)

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

20 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

How do I make a cube teleport after dropping below a point? 1 Answer

StartCoroutine gets the arglist type wrong 1 Answer

Simple Shooting Script 2 Answers

Starting a function as a coroutine in javascript using onclick via NGUI Button 1 Answer

How to make a variable double value? 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges