Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
This post has been wikified, any user with enough reputation can edit it.
avatar image
0
Question by Computa · Dec 22, 2012 at 07:45 PM · c#bugjumpingsidescroller

My jump charge script doesn't work. (C#)

So, I am making a controller for a 2d sidescroller. everything works well in my script, apart from my jumping. When I hold down the key, it jumps up and down rapidly. I can't figure out how to fix it. I'll give you the entire code because it has alot of important variables scattered through it; using UnityEngine; using System.Collections;

 public class sideScroller : MonoBehaviour {
     public float maxWalkSpeed = 5f;
     public float walkAcceleration = 0.05f;
     public float maxJumpHeight = 7.5f;
     public float jumpChargeRate = 0.25f;
     float currentWalk = 0f;
     float currentJump = 0f;
     bool ableToJump = false;
     bool hasJumped = false;
 
 
     // FixedUpdate is called once per frame
     void FixedUpdate () {
 
         if(Input.GetKey(KeyCode.D)) {
             currentWalk += walkAcceleration;
             if(currentWalk > maxWalkSpeed || currentWalk > -maxWalkSpeed) {
                 currentWalk = maxWalkSpeed;
             }
             transform.Translate(currentWalk * Time.deltaTime, 0f, 0f);
         } if(!Input.GetKey(KeyCode.D)) {
             currentWalk -= walkAcceleration;
             if(currentWalk < 0 || currentWalk > 0) {
                 currentWalk = 0;
             }
             transform.Translate(currentWalk * Time.deltaTime, 0f, 0f);
 
         }
         if(Input.GetKey(KeyCode.A)) {
             currentWalk -= walkAcceleration;
             if(currentWalk < maxWalkSpeed || currentWalk < -maxWalkSpeed) {
                 currentWalk = maxWalkSpeed;
             }
             transform.Translate(-currentWalk * Time.deltaTime, 0f, 0f);
         } if(!Input.GetKey(KeyCode.D)) {
             currentWalk += walkAcceleration;
             if(currentWalk > 0 || currentWalk < 0) {
                 currentWalk = 0;
             }
             transform.Translate(currentWalk * Time.deltaTime, 0f, 0f);
 
         }        if(Input.GetKeyUp(KeyCode.Space)) {
             print("Jump released.");
             ableToJump = true;
         }
             
         if(ableToJump = true) {
             ableToJump = false;
             transform.Translate(0f, currentJump, 0f);
             currentJump = 0f;
             hasJumped = true;
         }
     }
     void OnCollisionStay (Collision collision) {
         print("Touching world.");
         if(Input.GetKeyDown(KeyCode.Space)) {
             hasJumped = false;
             print("Jump charge started.");
             ableToJump = false;
             currentJump = 0f;
         }if(Input.GetKey(KeyCode.Space)) {
             print("Jump charging.");
             currentJump += jumpChargeRate;
         }if(currentJump > maxJumpHeight){
             currentJump = maxJumpHeight;
         }
 
     }
 }

So, on void Collision stay , it makes sure you cant double jump by having to touch an object to jump. It uses booleans to check if it has jumps and if it can jump. But when it is run, it rapidly bounces up and down. I'm using rigidbody for gravity, but disabling rotation on each axis, and I don't want the motion to be physically accurate so that's fine using transform.Translate. Can you guys tell me what I'm doing wrong? Don't just substitute my script because that isn't very helpful to be fair :) Thanks guys

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

0 Replies

· Add your reply
  • Sort: 

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

9 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

I have a problem with my sidescroller movement script 0 Answers

Better 2D Sprite Jump in 3D Plane 1 Answer

Multiple Cars not working 1 Answer

Distribute terrain in zones 3 Answers

Objects not becoming active with script 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges