Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by Commander Quackers · Dec 07, 2013 at 07:17 AM · fpsgunreloadnotworking

Gun reload not working?

Hello all, this is my ammo script attached to the gun:

 var Bullet : Rigidbody; //The bullet prefab is a Rigid body
 var Spawn : Transform; //Where the bullet shoots from
 var BulletSpeed : float = 1000; //How fast the bullet goes
 var ReloadTime : float = 2; //How long it takes to reload
 var AmmoInMag : float = 30; //How much ammo the gun carries
 var IsFullAuto = true;
 static var AmmoLeft : float;
 private var CanFire = true;
 var FireRate = 0.1;
 
 function Start () {
     AmmoLeft = AmmoInMag;
     }
 
 function Update () {
 
     if(IsFullAuto == false){
         if(Input.GetButtonDown("Fire1")){
             if(AmmoLeft > 0){
                 Fire();
             }
         }
     }
     else{
     if(Input.GetButton("Fire1")){
             if(AmmoLeft > 0){
                 Fire();
             }
         }
     }
 
 
     
     if(AmmoLeft == 0)
     {
         Reload();
     }
     
     if(AmmoLeft < 0){
         AmmoLeft = 0;
     }
 }
 function Fire(){
     if(CanFire == true){
         var bullet1 : Rigidbody = Instantiate(Bullet,Spawn.position,Spawn.rotation);
         bullet1.AddForce(bullet1.transform.right *BulletSpeed);
         CanFire = false;
         yield WaitForSeconds(FireRate);
         CanFire = true;
         AmmoLeft -= 1;
         audio.Play();    
     }
 }
 
 
 
 function Reload(){
     CanFire = false;
     yield WaitForSeconds(ReloadTime);
     CanFire = true;
 }

I can't figure out why, but all works until it has to reload - the gun will fire but when the AmmoInMag runs out, it doesn't seem to reload.. how can I fix this?

Help is appreciated + thanks in advance.

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
0
Best Answer

Answer by robertbu · Dec 07, 2013 at 07:31 AM

You're not putting any bullets back in the gun in your Reload() function. Between lines 59 and 60, add:

 AmmoLeft = AmmoInMag;
Comment
Add comment · Show 4 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Commander Quackers · Dec 07, 2013 at 07:41 AM 0
Share

This works, with no errors, but after the first reload, it fires more than 7 shots before reloading, why is this?

Side note - there are 7 bullets in the "AmmoIn$$anonymous$$ag" variable in the inspector.

avatar image robertbu · Dec 07, 2013 at 08:24 AM 0
Share

The problem is here:

 if(AmmoLeft == 0)
     {
        Reload();
     }

This is executed every frame in Update() during the time your code is waiting for 'ReloadTime'. This means a bunch of extra coroutines stack up refilling 'AmmoLeft'. This should fix it:

 if(AmmoLeft == 0 && CanFire)
     {
        Reload();
     }
avatar image Commander Quackers · Dec 07, 2013 at 08:29 AM 0
Share

Thanks, that did the job.

avatar image Pangamini · Dec 09, 2013 at 12:19 PM 0
Share

I recommend you to take a look at the concept of the state machines... It's not that complicated and very useful in game logic program$$anonymous$$g

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

17 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Switch Weapon Script Not taking effect HELP!! 2 Answers

How do I make an object move? 3 Answers

Reload help 1 Answer

Some issues with weapon switching and reloading? 2 Answers

Reload Mobile 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges