Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by Saerdev · Oct 02, 2014 at 11:46 PM · c#input

Separating Input.GetKey and Input.GetKeyDown

I'm using the observer pattern to create a layer of abstraction between player input and game logic. I have an InputManager class that other classes can subscribe to to listen for keypresses they're interested in. I've come across an issue where I need to differentiate between Input.GetKey and Input.GetKeyDown calls. E.g. Some spells can be cast as soon as they come off cooldown by holding down the key, but others can't. This would be a trivial fix if I hardcoded the condition into the spell script, but I'd rather keep all inputs in the InputManager class. How can I achieve this?

Comment
Add comment · Show 1
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image tanoshimi · Oct 03, 2014 at 06:48 AM 1
Share

I'm not sure I understand the problem: in the frame in which a key is pressed, both Get$$anonymous$$ey and Get$$anonymous$$eyDown are true because that's how they're defined ("Returns true if they key is down" and "returns true in the first frame in which the key is down").

If you want to "separate" them (by which I assume you want to make them mutually exclusive) you're going to have to change their definitions.

1 Reply

· Add your reply
  • Sort: 
avatar image
0

Answer by BenKurdziel · Oct 04, 2014 at 05:48 AM

I'd make a bool like "RefreshKeyPress" that you toggle. And a bool for each spell that checks if it requires you to "Refresh" your key press before it activates again.

Without testing anything, this is my guess at it:

so like

 if (Input.GetKey(KeyCode.Q))
 {
     if (spell1.requireRefresh)
     {
         if (RefreshKeyPress) 
             spell1.CastSpell();
     }
     else
         spell1.CastSpell();
    
     RefreshKeyPress = false;
 }
 else if (Input.GetKey(KeyCode.W))
 {
     if (spell2.requireRefresh)
     {
         if (RefreshKeyPress) 
             spell2.CastSpell();
     }
     else
         spell2.CastSpell();
 
      RefreshKeyPress = false;
 }
 else
 {
      RefreshKeyPress = true;
 }


Oh, and obviously you'd need to check the recharge time of the spell inside your CastSpell function in this instance. Otherwise you could always access it with spell1.CheckRecharge() or something and return true or false

 if (spell1.CheckRecharge())
 {
 
 }
 
 
 
 //In your spell's script
 
 public bool CheckRecharge ()
 {
     if (time >= rechargeTime)
         return true;
     else
         return false;
 }
Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

3 People are following this question.

avatar image avatar image avatar image

Related Questions

Multiple Cars not working 1 Answer

Distribute terrain in zones 3 Answers

Unity C# Two keys pressing one after another not doing a function vice versa 0 Answers

Divide screen in half for two buttons 1 Answer

Detect Gyroscope's rotation around a single axis? Like a car game. 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges