Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by JayFitz91 · Sep 01, 2014 at 11:08 PM · jumpgetbuttondownfire1

Problem with jump script

I have a ball rolling across the screen and I want it to jump everytime the "Fire1" button is clicked. This only occurs once or twice per number of clicks, where I need it to work everytime.

As far as I can see, there's nothing wrong, but it's late so I might be overlooking something so any help would be appreciated.

Here is my code:

 public class platform : MonoBehaviour 
 {
     public Rigidbody target;
     public int force = 250;
     public float speed = 0.1f;
     public int jumpHeight = 6;
     public bool isFalling = false;
 
     // Use this for initialization
     void Start () 
     {
     
     }
     
     // Update is called once per frame
     void Update () 
     {
 
         if(Input.GetKeyDown(KeyCode.R))
         {
             Application.LoadLevel(0);
         }
     }
     
     // Update is called once per frame
     void FixedUpdate () 
     {
         ballMovements ();    
     }
 
     void ballMovements()
     {
         rigidbody.AddRelativeTorque(Vector3.right * -1 * speed);
         
         if(Input.GetButtonDown("Fire1") && isFalling == false)
         {
             Debug.Log ("clicked");
             Vector3 temp = rigidbody.velocity;
             temp.y = jumpHeight;
             rigidbody.velocity = temp;
         }
         isFalling = true;
     }
     
     void OnCollisionStay()
     {
         isFalling = false;
     }
 }
Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
1
Best Answer

Answer by kacyesp · Sep 01, 2014 at 11:10 PM

You should not be taking user input during FixedUpdate(). Take inputs in Update().

Input.GetButtonDown() only returns true during the frame the button was pressed, so if FixedUpdate() occurred on any frames other than when the button was pressed, it will be false. Which is why your jump "sometimes" works.
Update() occurs every frame so that's why you should take inputs in Update().

Here's a solid explanation: http://gamedev.stackexchange.com/questions/73713/update-vs-fixedupdate-in-unity

And here's the fixed code:

 public class platform : MonoBehaviour 
 {
     public Rigidbody target;
     public int force = 250;
     public float speed = 0.1f;
     public int jumpHeight = 6;
     public bool isFalling = false;
     private bool isJumping = false;
 
  
     // Use this for initialization
     void Start () 
     {
  
     }
  
     // Update is called once per frame
     void Update () 
     {
  
         if(Input.GetKeyDown(KeyCode.R))
         {
             Application.LoadLevel(0);
         }
 
         if(Input.GetButtonDown("Fire1") && isFalling == false)
             isJumping = true;
 
     }
  
     // Update is called once per frame
     void FixedUpdate () 
     {
         ballMovements ();   
     }
  
     void ballMovements()
     {
         rigidbody.AddRelativeTorque(Vector3.right * -1 * speed);
  
         if( isJumping )
         {
             isJumping = false;
             Debug.Log ("clicked");
             Vector3 temp = rigidbody.velocity;
             temp.y = jumpHeight;
             rigidbody.velocity = temp;
         }
         isFalling = true;
     }
  
     void OnCollisionStay()
     {
         isFalling = false;
     }
 }

Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image JayFitz91 · Sep 01, 2014 at 11:44 PM 1
Share

Thanks for the link, cleared things up for me, the code works great too, thanks for the help

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

23 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

GetButtonDown is unresponsive 0 Answers

Jumping not allways registering fix? 0 Answers

Problem playing animation C# 1 Answer

Input.GetButtonDown inconsistent 1 Answer

Jumping through the roof! 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges