Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
  • Help Room /
avatar image
0
Question by sean2022 · Mar 15 at 11:59 AM · c#input

,Why isnt my attack working?

So I have two scripts, player movement and player attack. My can attack method is in the player movement script and I want to use it in the player attack. However when I type it into the player attack script it doesn't turn yellow like the other methods. I now cant attack in the game and I don't know how to fix it. Anyone know how to help? Here are both the scripts, player movement first.

using UnityEngine;

public class PlayerMovement : MonoBehaviour { [SerializeField] private float speed; [SerializeField] private float jumpPower; [SerializeField] private LayerMask groundLayer; [SerializeField] private LayerMask wallLayer; private Rigidbody2D body; private Animator anim8; private BoxCollider2D boxCollider; private float wallJumpCooldown; private float horizontalInput;

 private void Awake()
 {
     body = GetComponent<Rigidbody2D>();
     anim8 = GetComponent<Animator>();
     boxCollider = GetComponent<BoxCollider2D>();
 }

 private void Update()
 {
      horizontalInput = Input.GetAxis("Horizontal");
     

     if (horizontalInput > 0.01f)
         transform.localScale = Vector3.one;
     else if (horizontalInput < -0.01f)
         transform.localScale = new Vector3(-1, 1, 1);
    

     //animator parameters
     anim8.SetBool("Run", horizontalInput != 0);
     anim8.SetBool("grounded", isGrounded());

     //wall jumping
     if (wallJumpCooldown > 0.2f)
     {


         body.velocity = new Vector2(horizontalInput * speed, body.velocity.y);

         if (onWall() && !isGrounded())
         {
             body.gravityScale = 0;
             body.velocity = Vector2.zero;

         }

         else
             body.gravityScale = 7;

         if (Input.GetKey(KeyCode.Space))
             Jump();


     }
     else
         wallJumpCooldown += Time.deltaTime;






 }

 private void Jump()//jump method
 {
     if (isGrounded())
     {
         body.velocity = new Vector2(body.velocity.x, jumpPower);
         anim8.SetTrigger("Jump");
     }
    else if (onWall() && !isGrounded())
     {
         if (horizontalInput == 0)
         {
             body.velocity = new Vector2(-Mathf.Sign(transform.localScale.x) * 10, 0);
             transform.localScale = new Vector3(-Mathf.Sign(transform.localScale.x), transform.localScale.y, transform.localScale.z);
         }
         else
             body.velocity = new Vector2(-Mathf.Sign(transform.localScale.x) * 3, 6);

         wallJumpCooldown = 0;
         

     }
 


 }

  

 private bool isGrounded()
 {
     RaycastHit2D raycastHit = Physics2D.BoxCast(boxCollider.bounds.center, boxCollider.bounds.size, 0, Vector2.down, 0.1f, groundLayer);
     return raycastHit.collider != null; 

 }

 private bool onWall()
 {
     RaycastHit2D raycastHit = Physics2D.BoxCast(boxCollider.bounds.center, boxCollider.bounds.size, 0, new Vector2(transform.localScale.x, 0), 0.1f, wallLayer);
     return raycastHit.collider != null;

 }

 public bool canAttack()
 {
     
     return horizontalInput == 0 && isGrounded() && !onWall();

 }

}

now player attack

using UnityEngine;

public class PlayerAttack : MonoBehaviour {

     [SerializeField] private float attackCooldown;
     private Animator anim8;
     private PlayerMovement playerMovement;
     private float cooldownTimer = Mathf.Infinity;
     

     
 
     private void awake()
     {
     anim8 = GetComponent<Animator>();
     playerMovement = GetComponent<PlayerMovement>();
     }

     private void update()
     {
     if (Input.GetMouseButton(0) && cooldownTimer > attackCooldown && playerMovement.canAttack())
         attack();

     cooldownTimer += Time.deltaTime;
     }

     private void attack()
     {
     anim8.SetTrigger("Attack");
     cooldownTimer = 0;
     }

   


},So I have two scripts, player movement and player attack. My can attack method is in the player movement script and I want to use it in the player attack. However when I type it into the player attack script it doesn't turn yellow like the other methods. I now cant attack in the game and I don't know how to fix it. Anyone know how to help? Here are both the scripts, player movement first.

using UnityEngine;

public class PlayerMovement : MonoBehaviour { [SerializeField] private float speed; [SerializeField] private float jumpPower; [SerializeField] private LayerMask groundLayer; [SerializeField] private LayerMask wallLayer; private Rigidbody2D body; private Animator anim8; private BoxCollider2D boxCollider; private float wallJumpCooldown; private float horizontalInput;

 private void Awake()
 {
     body = GetComponent<Rigidbody2D>();
     anim8 = GetComponent<Animator>();
     boxCollider = GetComponent<BoxCollider2D>();
 }

 private void Update()
 {
      horizontalInput = Input.GetAxis("Horizontal");
     

     if (horizontalInput > 0.01f)
         transform.localScale = Vector3.one;
     else if (horizontalInput < -0.01f)
         transform.localScale = new Vector3(-1, 1, 1);
    

     //animator parameters
     anim8.SetBool("Run", horizontalInput != 0);
     anim8.SetBool("grounded", isGrounded());

     //wall jumping
     if (wallJumpCooldown > 0.2f)
     {


         body.velocity = new Vector2(horizontalInput * speed, body.velocity.y);

         if (onWall() && !isGrounded())
         {
             body.gravityScale = 0;
             body.velocity = Vector2.zero;

         }

         else
             body.gravityScale = 7;

         if (Input.GetKey(KeyCode.Space))
             Jump();


     }
     else
         wallJumpCooldown += Time.deltaTime;






 }

 private void Jump()//jump method
 {
     if (isGrounded())
     {
         body.velocity = new Vector2(body.velocity.x, jumpPower);
         anim8.SetTrigger("Jump");
     }
    else if (onWall() && !isGrounded())
     {
         if (horizontalInput == 0)
         {
             body.velocity = new Vector2(-Mathf.Sign(transform.localScale.x) * 10, 0);
             transform.localScale = new Vector3(-Mathf.Sign(transform.localScale.x), transform.localScale.y, transform.localScale.z);
         }
         else
             body.velocity = new Vector2(-Mathf.Sign(transform.localScale.x) * 3, 6);

         wallJumpCooldown = 0;
         

     }
 


 }

  

 private bool isGrounded()
 {
     RaycastHit2D raycastHit = Physics2D.BoxCast(boxCollider.bounds.center, boxCollider.bounds.size, 0, Vector2.down, 0.1f, groundLayer);
     return raycastHit.collider != null; 

 }

 private bool onWall()
 {
     RaycastHit2D raycastHit = Physics2D.BoxCast(boxCollider.bounds.center, boxCollider.bounds.size, 0, new Vector2(transform.localScale.x, 0), 0.1f, wallLayer);
     return raycastHit.collider != null;

 }

 public bool canAttack()
 {
     
     return horizontalInput == 0 && isGrounded() && !onWall();

 }

}

now player attack

using UnityEngine;

public class PlayerAttack : MonoBehaviour {

     [SerializeField] private float attackCooldown;
     private Animator anim8;
     private PlayerMovement playerMovement;
     private float cooldownTimer = Mathf.Infinity;
     

     
 
     private void awake()
     {
     anim8 = GetComponent<Animator>();
     playerMovement = GetComponent<PlayerMovement>();
     }

     private void update()
     {
     if (Input.GetMouseButton(0) && cooldownTimer > attackCooldown && playerMovement.canAttack())
         attack();

     cooldownTimer += Time.deltaTime;
     }

     private void attack()
     {
     anim8.SetTrigger("Attack");
     cooldownTimer = 0;
     }

   


}

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

0 Replies

· Add your reply
  • Sort: 

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

813 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

(Newbie's First Project) Object doesn't stop moving until long after I let go of the button 1 Answer

Implementing Airbrake mechanics like in Wipeout/BallisticNG,Implementing airbraking for a Wipeout/FZero style game 0 Answers

How to specify forward direction for my character? 0 Answers

GetBindingDisplayString() returns an empty string for certain bindings? 1 Answer

Problems with touch input. 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges