Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by Bloodyem · Oct 23, 2014 at 12:05 PM · c#loopingwhilewhile-loop

While loop won't stop crashing!!!

I am trying to make a while loop. I've no idea why the condition won't terminate.

Here's my code:

 public void Damaged (float _timer, Vector3 _direct) {
         Debug.Log (HitTimer);
         while (HitTimer < _timer) 
                   {
             transform.position += _direct * MovementSpeed * Time.deltaTime;
               }

In this, HitTimer is increasing by Time.deltatime in the update function, being zeroed out before the start, (I've checked that), and _timer is .5f; I can't think of why this isn't ending. Any ideas?

Comment
Add comment · Show 2
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Dimling · Oct 23, 2014 at 12:16 PM 0
Share

Have you tried to Debug.Log both HitTimer and _timer inside of the loop to see what the values are while the program is running?

avatar image MrSoad · Oct 23, 2014 at 12:23 PM 0
Share

What do you mean by " being zeroed out before the start"? Where is it being zeroed out...? Please can you post the code that has this in it, thanks.

1 Reply

· Add your reply
  • Sort: 
avatar image
9
Best Answer

Answer by Bunny83 · Oct 23, 2014 at 12:23 PM

Unity uses a single thread for the whole scripting environment and that's the main thread. If you doing a while loop like this the current frame will be stuck inside that while loop. Since nothing else is executed besides what's inside that while loop you will never exit the while loop because HitTimer nor _timer can't possibly change.

You might want to create a coroutine for this. This allows you to write "sequential code" which can be interrupted at yield statements :

 public IEnumerator Damaged (float _timer, Vector3 _direct)
 {
     Debug.Log (HitTimer);
     while (HitTimer < _timer)
     {
         transform.position += _direct * MovementSpeed * Time.deltaTime;
         yield return null; // leave the coroutine and come back next frame
     }
 }


To start a coroutine you have to use StartCoroutine. Instead of just calling the method you have to pass the result to StartCoroutine:

 StartCoroutine(Damaged(yourTimerValue, yourDirectVector));
Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Bloodyem · Oct 23, 2014 at 08:36 PM 0
Share

This did it! Thank you so much, I think I understand better now!

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

31 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Multiple Cars not working 1 Answer

Distribute terrain in zones 3 Answers

Callback from a Loop 1 Answer

Why does it seem as if my code is exuting in wrong order? 0 Answers

How can I constantly change the position of a target when an object reaches it. 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges