Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by salad__fingers · May 23, 2012 at 08:40 PM · c#error

Unfixable Assets/Scripts/PlayerAttack.cs(30,15): error CS1525: Unexpected symbol `private'

Assets/Scripts/PlayerAttack.cs(30,15): error CS1525: Unexpected symbol `private' Here is my code, which is where my problem is, and it seems impossible to fix, because everything I have tried, from extra curly braces to different tabs.

     using UnityEngine;
     using System.Collections;
     
     public class PlayerAttack : MonoBehaviour {
         public GameObject target;
         public float attackTimer;
         public float coolDown;
         
         // Use this for initialization
         void Start () {
             attackTimer = 0;
             coolDown = 2.0f;    
         }
         
         // Update is called once per frame
         void Update () {
             if(attackTimer > 0)
                 attackTimer -= Time.deltaTime;
             
             if(attackTimer < 0)
                 attackTimer = 0;
             
             if(Input.GetKeyUp(KeyCode.F)) {
                 if(attackTimer = 0) {
                 Attack();
                 attackTimer = coolDown;
             }
         }
         
         private void Attack(){
             
             float distance = Vector3.Distance(target.transform.position, transform.position);
             
             Vector3 dir = (target.transform.position - transform.position).normalized;
             
             float direction = Vector3.Dot(dir, transform.forward);
             
         Debug.Log(direction);
             
         if(distance < 2.5f) {
             if(direction > 0) {
                 EnemyHealth eh = (EnemyHealth)target.GetComponent("EnemyHealth");
                 eh.AddjustCurrentHealth(-10);
                     }
                 }
             }
         }
Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
0
Best Answer

Answer by rutter · May 23, 2012 at 09:01 PM

The sample code you've posted has unbalanced braces in the Update() function. Looks like you missed a closing brace on one of those if blocks.

If you're using MonoDevelop, placing the text cursor immediately next to a brace or paren will highlight its opening/closing partner -- this is very handy for spotting problems like this one.

Comment
Add comment · Show 4 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image salad__fingers · May 23, 2012 at 09:19 PM 0
Share

I do not understand what you are saying. I put my cursor over the brace, but nothing happens. I am using $$anonymous$$onoDevelop. If you can, by chance, can you fix the code for me?

avatar image Wolfram · May 23, 2012 at 10:01 PM 1
Share

Add another } at the end of the Update function, this will fix the error. You should take care of proper indenting, which will help you spot these mistakes: The lines after "if(attackTimer = 0) {" should be indented one level deeper. Also, the statement "if(attackTimer = 0)" in itself is erroneous - it creat at least another compiler warning, if not an error. To compare A to B, use "A==B" - "A=B "is an assignment.

avatar image salad__fingers · May 23, 2012 at 11:33 PM 0
Share

Okay, I did what you said, and it worked, and now I am getting "Cannot implicitly convert type float' to bool'"

avatar image rutter · May 24, 2012 at 11:03 PM 0
Share

Like they said, this:

 if (attackTimer = 0)

Needs to be this:

 if (attackTimer == 0)

= and == look similar, but do completely different things.

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

5 People are following this question.

avatar image avatar image avatar image avatar image avatar image

Related Questions

Error trying to createMonoBehaviour using the 'new' keyword in cSharp script 4 Answers

Combine two scripts 0 Answers

ArgumentOutOfRangeException: Argument is out of range. Parameter name: index System. 0 Answers

Distribute terrain in zones 3 Answers

Identifier help 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges