Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by Babilinski · Nov 09, 2011 at 04:05 AM · c#collisiontargetingadding

my adding target script wont stop adding targets.

 void Update () {
     
        Collider[] cols = Physics.OverlapSphere(transform.position, 10);
 foreach (Collider enemy in cols){
     if (enemy && enemy.tag == "Enemy"){
             
             targets.Add(enemy.transform);
             
             
     
         }
     }


(targes is a list that you use to target enemies.)

my problem is that when I stand in distance of the enemy it adds a lot of redundant targets.

does anyone know the problem?

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

2 Replies

· Add your reply
  • Sort: 
avatar image
0

Answer by syclamoth · Nov 09, 2011 at 04:32 AM

Yes, it's simply because you're adding all the targets every single frame!

Now, I only know how to solve this one because I've been looking at your other posts...

 if(enemy && enemy.tag == "Enemy" && !targets.Contains(enemy.transform))
 {
     targets.Add(enemy.transform);
 }

That's probably more like what you're looking for, since it checks for the enemy's presence in the list before adding it!

An issue here that you will have to deal with is that the targets will remain even when they are no longer in range (because you never remove them from the list).

Now, as I've said before, this is still not a fantastic way of going about it. If you just used my script the way I'd told you earlier, you wouldn't be getting this problem!

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image
0

Answer by Bunny83 · Nov 09, 2011 at 04:37 AM

I guess it would make more sense to renew the target list instead of just checking for redundant items. If you add a target it would never be removed. Just clear the target list before you add the current targets:

 void Update()
 {
     Collider[] cols = Physics.OverlapSphere(transform.position, 10);
     targets.Clear();
     foreach (Collider enemy in cols)
     {
         if (enemy && enemy.tag == "Enemy")
         {
             targets.Add(enemy.transform);
         }
     }
 }
Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Bunny83 · Nov 09, 2011 at 04:41 AM 0
Share

ps. for performance reason you should place your enemies on a seperate layer and do the OverlapSphere only for that layer. That would increase the speed and you wouldn't have to check for the enemy tag.

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

4 People are following this question.

avatar image avatar image avatar image avatar image

Related Questions

Multiple Cars not working 1 Answer

Health Script/Targeting system c# 2 Answers

Distribute terrain in zones 3 Answers

Checking collision between 2 objects on 3rd object 0 Answers

Problem with collision detection 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges