Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
  • Help Room /
avatar image
0
Question by honzapat · Dec 10, 2018 at 09:03 PM · c#input

Help with improving, dynamisation of Input code

Hi for last 3 days i am working on custom input manager bcz of really bad default one. It is in working condition but iam pretty unsatisfied with hardcoded parts unnecesary parts and iam just too over to realize solution. Iam linking whole script [link text][1]

Main part you can see

 public class ModTemplate
     {
         public bool isJosystick = false;
         public bool connected = false;
         public PlayerIndex jNum;
         // public Dictionary<Action, string> template = new Dictionary<Action, string>();
         [SerializeField]
         public static Action[] template156;
     }
 
     public static ModTemplate playertemp = new ModTemplate();
 

I tried to integrate dynamic Actions but i would also need editor so i dropped editor and iam actually figuring out this.

 static private Action GetInternalAction(template actual, string actionname)
     {
         if (actionname == "horizontal")
         {
             return actual.horizontal;
         }
         if (actionname == "vertical")
         {
             return actual.vertical;
         }
         if (actionname == "firebtn")
         {
             return actual.firebtn;
         }
         if (actionname == "jumpbtn")
         {
             return actual.jumpbtn;
         }        
         if (actionname == "usebtn")
         {
             return actual.usebtn;
         }
         if (actionname == "changebtn")
         {
             return actual.changebtn;
         }
         else
         {
             return null;
         }
         
     }

Iam 100% sure this can be somehow shrinked to 1line

  static ButtonState GetPrevJButton(string button)
     {
         
         if (button == "A")
         {            
            return prevState.Buttons.A;
         }
         if (button == "B")
         {
             return prevState.Buttons.B;
         }
         if (button == "X")
         {
             return prevState.Buttons.X;
         }
         if (button == "Y")
         {
             return prevState.Buttons.Y;
         }
         if (button == "Lstick")
         {
             return prevState.Buttons.LeftStick;
         }
         if (button == "Rstick")
         {
             return prevState.Buttons.RightStick;
         }
         if (button == "Lshoulder")
         {
             return prevState.Buttons.LeftShoulder;
         }
         if (button == "Rshoulder")
         {
             return prevState.Buttons.RightShoulder;
         }
         if (button == "Back")
         {
             return prevState.Buttons.Back;
         }
         if (button == "Start")
         {
             return prevState.Buttons.Start;
         }
 
 
         if (button == "DpadUp")
         {
             return prevState.DPad.Up;
         }
         if (button == "DpadDown")
         {
             return prevState.DPad.Down;
         }
         if (button == "DpadLeft")
         {
             return prevState.DPad.Left;
         }
         if (button == "DpadRight")
         {
             return prevState.DPad.Right;
         }
 
 
         else
         {
             return prevState.Buttons.LeftStick;
         }
     }
     static ButtonState GetJButton(string button)
     {
 
         if (button == "A")
         {
             return state.Buttons.A;
         }
         if (button == "B")
         {
             return state.Buttons.B;
         }
         if (button == "X")
         {
             return state.Buttons.X;
         }
         if (button == "Y")
         {
             return state.Buttons.Y;
         }
         if (button == "Lstick")
         {
             return state.Buttons.LeftStick;
         }
         if (button == "Rstick")
         {
             return state.Buttons.RightStick;
         }
         if (button == "Lshoulder")
         {
             return state.Buttons.LeftShoulder;
         }
         if (button == "Rshoulder")
         {
             return state.Buttons.RightShoulder;
         }
         if (button == "Back")
         {
             return state.Buttons.Back;
         }        
         if (button == "Start")
         {
             return state.Buttons.Start;
         }
         
         if (button == "DpadUp")
         {
             return state.DPad.Up;
         }
         if (button == "DpadDown")
         {
             return state.DPad.Down;
         }
         if (button == "DpadLeft")
         {
             return state.DPad.Left;
         }
         if (button == "DpadRight")
         {
             return state.DPad.Right;
         }
 
 
         else
         {
             return state.Buttons.RightStick;
         }
     }

Same these 2

And should i even use static i still need to have it put atleast once somewhere to tick the update. Any suggestions? [1]: /storage/temp/129212-ncinput.zip

ncinput.zip (2.5 kB)
Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
0

Answer by Cornelis-de-Jager · Dec 10, 2018 at 09:06 PM

Try:

 Return Input.inputString
Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image honzapat · Dec 10, 2018 at 09:46 PM 0
Share

On which part?

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

626 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Problems with touch input. 0 Answers

Input.GetKeyDown not reading? Am I being oblivious? 1 Answer

(Newbie's First Project) Object doesn't stop moving until long after I let go of the button 1 Answer

Pro controller not vibrating 0 Answers

Acceleration only increasing when I press a key 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges