Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by JuanseCoello · Nov 03, 2013 at 02:54 AM · charactercontrollercontrollerjump

Jump gets disabled with courutine!

I have two scripts, they work perfectly, they move the character around and make it jump, but when I apply the courutine, wich works perfectly with a debug log, the jump simply doesnt work, the character doesnt jump anymore when I press the spacebar. How come is this??

Here are the codes.

TP MOTOR

using UnityEngine; using System.Collections;

public class TP_Motor : MonoBehaviour {

 public static TP_Motor Instance;

 public float MoveSpeed = 20f;
 public float JumpSpeed = 13f;
 public float Gravity = 31f;
 public float TerminalVelocity = 60f;

 public Vector3 MoveVector { get; set; }
 public float VerticalVelocity { get; set; }

 void Awake () 
 {
     Instance = this;
 }
 
 public void UpdateMotor () 
 {
     ProcessMotion();

 }

 public void ProcessMotion()
 {
     // First Movevector

     // Transform MoveVector to worldspace
     MoveVector = transform.TransformDirection(MoveVector);

     // Normalize MoveVector if Magnitude > 1
     if (MoveVector.magnitude > 1)
         MoveVector = Vector3.Normalize(MoveVector);

     // Multiply MoveVector by MoveSpeed
     MoveVector *= MoveSpeed;

     // Reapply VerticalVelocity MoveVector.y
     MoveVector = new Vector3(MoveVector.x, VerticalVelocity, MoveVector.z);

     // Apply Gravity
     ApplyGravity();

     // Move the character into world space
     TP_Controller.CharacterController.Move(MoveVector * Time.deltaTime);
 }

 void ApplyGravity()
 {
     if (MoveVector.y > -TerminalVelocity)
         MoveVector = new Vector3(MoveVector.x, MoveVector.y - Gravity * Time.deltaTime, MoveVector.z);

     if (TP_Controller.CharacterController.isGrounded && MoveVector.y < -1)
         MoveVector = new Vector3(MoveVector.x, -1, MoveVector.z);
 }

 public void Jump()
 {
     if (TP_Controller.CharacterController.isGrounded)
         VerticalVelocity = JumpSpeed;
 }

}

TP CONTROLLER

using UnityEngine; using System.Collections;

public class TP_Controller : MonoBehaviour {

 public static CharacterController CharacterController;
 public static TP_Controller Instance;

 float rotateSpeed = 60.0f;

 void Awake()
 {
     CharacterController = GetComponent("CharacterController") as CharacterController;

     Instance = this;

 }


 void Update()
 {
     GetLocomotionInput();
     HandleActionInput();
     TP_Motor.Instance.UpdateMotor();
 }

 void GetLocomotionInput() // INPUTS FOR MOTION
 {
     var deadZone = 0.1f;

     TP_Motor.Instance.VerticalVelocity = TP_Motor.Instance.MoveVector.y;

     TP_Motor.Instance.MoveVector = Vector3.zero;

     if (((Input.GetAxis("Vertical") > deadZone) && !Input.GetKey(KeyCode.LeftShift)) ||
         (Input.GetAxis("Vertical") < -deadZone && !Input.GetKey(KeyCode.LeftShift)))
         TP_Motor.Instance.MoveVector += new Vector3(0, 0, Input.GetAxis("Vertical"));

     if (Input.GetKey(KeyCode.LeftShift) & Input.GetKey("d"))
         TP_Motor.Instance.MoveVector += new Vector3(Input.GetAxis("Horizontal"), 0, 0);

     if (Input.GetKey(KeyCode.LeftShift) & Input.GetKey("a"))
         TP_Motor.Instance.MoveVector += new Vector3(Input.GetAxis("Horizontal"), 0, 0);

     if (Input.GetKey(KeyCode.LeftShift) & Input.GetKey("right"))
         TP_Motor.Instance.MoveVector += new Vector3(Input.GetAxis("Horizontal"), 0, 0);

     if (Input.GetKey(KeyCode.LeftShift) & Input.GetKey("left"))
         TP_Motor.Instance.MoveVector += new Vector3(Input.GetAxis("Horizontal"), 0, 0);

     if (((Input.GetAxis("Horizontal") > deadZone) && !Input.GetKey(KeyCode.LeftShift)) ||
         (Input.GetAxis("Horizontal") < -deadZone) && !Input.GetKey(KeyCode.LeftShift))
         transform.eulerAngles += new Vector3(0, Input.GetAxis("Horizontal") * rotateSpeed * Time.deltaTime, 0);
 }

 void HandleActionInput()
 {
     if (Input.GetKeyDown(KeyCode.Space))
     {
         StartCoroutine(DelayedJump());
     }
 }

 public void Jump()
 {
     TP_Motor.Instance.Jump();
 }

 IEnumerator DelayedJump()
 {
     yield return new WaitForSeconds(1f);
     Jump();
 }

}

Comment
Add comment · Show 1
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image eskimojoe · Nov 03, 2013 at 09:43 AM 0
Share

What is the exact error message?

1 Reply

· Add your reply
  • Sort: 
avatar image
1

Answer by Programmer-Tau · Nov 03, 2013 at 03:28 PM

The coroutine was changing the order of operations. In your code, you have a variable called VerticalVelocity, which gets the upward velocity and is used in ProcessMotion function. However, once you added the coroutine, the order of operation changed, and the VerticalVelocity variable was getting reset inside GetLocomotionInput().

I moved the line of code from GetLocomotionInput() to the end of ProcessMotion, and this fixes your current problem. It jumped correctly on my machine, at least. Below is the fixed code.

I'd encourage you to learn how to use the debugger. This was a relatively straightforward bug to fix using a debugger.

Here's the new TP_Motor:

 using UnityEngine; using System.Collections;
 
 public class TP_Motor : MonoBehaviour {
 
 public static TP_Motor Instance;
  
 public float MoveSpeed = 20f;
 public float JumpSpeed = 13f;
 public float Gravity = 31f;
 public float TerminalVelocity = 60f;
  
 public Vector3 MoveVector { get; set; }
 public float VerticalVelocity { get; set; }
  
 void Awake () 
 {
     Instance = this;
 }
  
 public void UpdateMotor () 
 {
     ProcessMotion();
  
 }
  
 public void ProcessMotion()
 {
     // First Movevector
  
     // Transform MoveVector to worldspace
     MoveVector = transform.TransformDirection(MoveVector);
  
     // Normalize MoveVector if Magnitude > 1
     if (MoveVector.magnitude > 1)
         MoveVector = Vector3.Normalize(MoveVector);
  
     // Multiply MoveVector by MoveSpeed
     MoveVector *= MoveSpeed;
  
     // Reapply VerticalVelocity MoveVector.y
     MoveVector = new Vector3(MoveVector.x, VerticalVelocity, MoveVector.z);
  
     // Apply Gravity
     ApplyGravity();
  
     // Move the character into world space
     TP_Controller.CharacterController.Move(MoveVector * Time.deltaTime);
         
         
  
     VerticalVelocity = MoveVector.y;
 }
  
 void ApplyGravity()
 {
     if (MoveVector.y > -TerminalVelocity)
         MoveVector = new Vector3(MoveVector.x, MoveVector.y - Gravity * Time.deltaTime, MoveVector.z);
  
     if (TP_Controller.CharacterController.isGrounded && MoveVector.y < -1)
         MoveVector = new Vector3(MoveVector.x, -1, MoveVector.z);
 }
  
 public void Jump()
 {
     if (TP_Controller.CharacterController.isGrounded)
         VerticalVelocity = JumpSpeed;
 }
 }
 

Here's the new TP_Controller:

 public static CharacterController CharacterController;
 public static TP_Controller Instance;
  
 float rotateSpeed = 60.0f;
  
 void Awake()
 {
     CharacterController = GetComponent("CharacterController") as CharacterController;
  
     Instance = this;
  
 }
  
  
 void Update()
 {
     GetLocomotionInput();
     HandleActionInput();
     TP_Motor.Instance.UpdateMotor();
 }
  
 void GetLocomotionInput() // INPUTS FOR MOTION
 {
     var deadZone = 0.1f;
  
     TP_Motor.Instance.MoveVector = Vector3.zero;
  
     if (((Input.GetAxis("Vertical") > deadZone) && !Input.GetKey(KeyCode.LeftShift)) ||
         (Input.GetAxis("Vertical") < -deadZone && !Input.GetKey(KeyCode.LeftShift)))
         TP_Motor.Instance.MoveVector += new Vector3(0, 0, Input.GetAxis("Vertical"));
  
     if (Input.GetKey(KeyCode.LeftShift) & Input.GetKey("d"))
         TP_Motor.Instance.MoveVector += new Vector3(Input.GetAxis("Horizontal"), 0, 0);
  
     if (Input.GetKey(KeyCode.LeftShift) & Input.GetKey("a"))
         TP_Motor.Instance.MoveVector += new Vector3(Input.GetAxis("Horizontal"), 0, 0);
  
     if (Input.GetKey(KeyCode.LeftShift) & Input.GetKey("right"))
         TP_Motor.Instance.MoveVector += new Vector3(Input.GetAxis("Horizontal"), 0, 0);
  
     if (Input.GetKey(KeyCode.LeftShift) & Input.GetKey("left"))
         TP_Motor.Instance.MoveVector += new Vector3(Input.GetAxis("Horizontal"), 0, 0);
  
     if (((Input.GetAxis("Horizontal") > deadZone) && !Input.GetKey(KeyCode.LeftShift)) ||
         (Input.GetAxis("Horizontal") < -deadZone) && !Input.GetKey(KeyCode.LeftShift))
         transform.eulerAngles += new Vector3(0, Input.GetAxis("Horizontal") * rotateSpeed * Time.deltaTime, 0);
 }
  
 void HandleActionInput()
 {
     if (Input.GetKeyDown(KeyCode.Space))
     {
         StartCoroutine(DelayedJump());
     }
 }
  
 public void Jump()
 {
     TP_Motor.Instance.Jump();
 }
  
 IEnumerator DelayedJump()
 {
     yield return new WaitForSeconds(1f);
     Jump();
 }
 }
Comment
Add comment · Show 2 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image JuanseCoello · Nov 04, 2013 at 01:44 AM 0
Share

Thanks, it worked you are a genius, you have a like from me, but I dont quite well understand what happened. :(

avatar image JuanseCoello · Nov 04, 2013 at 02:15 AM 0
Share

Hey do you have facebook or something? so I can ask for help when I have a problem, you are really a genius and a very useful contact. This is my facebook by the way: https://www.facebook.com/juanse.coello
and my email is juansecoello@gmail.com $$anonymous$$illion thanks!!!

Blockquote

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

17 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

How to fix a infinity jump? 1 Answer

Custom Character Script Allowing Movement in the Air? 0 Answers

Let Character Controller jump. 0 Answers

Let Character Controller jump. 1 Answer

why does character controller accelerate off ledges? 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges