Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by naf456 · Oct 15, 2011 at 06:25 PM · update

Code isn't Recursive in update?

Hey there. I have a problem with a section of code in my weapon script. Simply put, it won't call fire multiple times :

 void Update() {
     //Updates ammo Meter
     if(ammoBox == 0 && clipBullets == 0)
     {
         lcdMeter.text = "--";
     }
     else
     lcdMeter.text = clipBullets.ToString();
     
     int count = Input.touchCount;
     
     for(int i = 0;i < count; i++)
     {
         Touch touch = Input.GetTouch(i);                
         bool shouldLatchFinger = false;
         Vector2 firstTouch = Vector2.zero;
         
         if(touch.phase == TouchPhase.Began)
         {
             firstTouch = new Vector2(touch.position.x, -touch.position.y + Screen.height);
             print("i");
         }
         else if(touch.phase == TouchPhase.Canceled || touch.phase == TouchPhase.Ended)
         {
             firstTouch = Vector2.zero;
             print(firstTouch);
         }
         
         if(fireButtonRect.Contains(firstTouch))
         {
             print("Fire!");
             // Keep firing until we used up the fire time
             if( prevFire + fireRate <= Time.time) 
             {
                 FireWeapon();
                 prevFire = Time.time;
             }
         }
     }
 }

The problem is that it doesn't trigger the "Fire!" continuously. it fire it once...which I really don't get...

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

2 Replies

· Add your reply
  • Sort: 
avatar image
1
Best Answer

Answer by Bunny83 · Oct 18, 2011 at 11:27 PM

Your problem seems to be the declaration of your firstTouch variable. You declared it inside Update (even inside the touch loop) so it gets reset every time you run through the loop. You set the firstTouch var only at TouchPhase.Began which happens only once when you start touching the display.

Just move the declaration out of Update and put it into your script-scope, that should do the trick.

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image
0

Answer by DaveA · Oct 15, 2011 at 06:37 PM

Are you sure about if( prevFire + fireRate = ?

Comment
Add comment · Show 2 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image naf456 · Oct 15, 2011 at 08:35 PM 0
Share

Yes. it has worked before - when I was was using a recursive Button. And note that the print function is outside that if statement.

avatar image Bunny83 · Oct 18, 2011 at 11:35 PM 0
Share

@DaveA: well i was also confused because the if statement is reversed as you would expect. Usually you put the value that you want to check first. In this case the variable that is going to change is Time.time, so you would check if Time.time is greater than your reference. I'm not sure how those peoples $$anonymous$$ds works. It's so un-natural the other way round but it doesn't matter of course. It's just hard to read.

Personally i would calculate the "timeout" value at the point of assignment:

 if( Time.time >= timeOut ) 
 {
     FireWeapon();
     timeOut = Time.time + fireRate;
 }

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

4 People are following this question.

avatar image avatar image avatar image avatar image

Related Questions

How do you update code/stage/screen at runtime? 1 Answer

Static recursive function syncing? 2 Answers

Coroutine - events not working 2 Answers

How to detect empty slot and spawn gameobject there? 1 Answer

Asset Server problems. Old updates appearing in updates list after deleting assets 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges