Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by mellowninja · May 18, 2012 at 11:21 PM · animationpickupdrop

Pickup script error

Okay so the pick up script works great i can pick up my object and have it apear in my characters hand.

 using UnityEngine;
 
 using System.Collections;
 
 public class PlaceItem : MonoBehaviour 
 
 {
 
     private bool inRange = false;
 
     public bool Activated { get; set; }
 
     void Awake()
     {
     
 
     }
 
    void OnTriggerEnter()
     {
         inRange = true;
         Debug.Log("in range of alter place item");
     }
 
    void OnTriggerExit()
    {
 
         inRange = false;
 
         Debug.Log("out of range of alter ");
     }
 
     void Update()
     {
 
          if (TP_Controller.Instance.ObjectHeld != null)
          {
 
                 if (inRange && TP_Controller.Instance.IsHolding == Input.GetKeyDown(KeyCode.E))
 
             {
                 animation.Play("WIN");// if the item has an animation 
                 //transform.Find("SuperOrb1").renderer.enabled = true;
 
                 TP_Controller.Instance.IsHolding = false;
                 Activated = true;
                 GameObject.Destroy(TP_Controller.Instance.ObjectHeld.gameObject);
                 TP_Controller.Instance.Use(); //-- this will animate the character in CControler and animator 
                }
          }
     }
 }

This script allows me to place the item on a trigger when the character is holding the item then press E to add to the alter.

The problem is that when i go to the alter and press E without the object held it still activates, can anyone help ?

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
0

Answer by aldonaletto · May 18, 2012 at 11:47 PM

I suspect you should explicitly assign null to Instance.ObjectHeld when destroying the associated game object:

     Destroy(TP_Controller.Instance.ObjectHeld.gameObject);
     TP_Controller.Instance.ObjectHeld = null;
   

I also think you should modify the second if like this:

   if (inRange && TP_Controller.Instance.IsHolding && Input.GetKeyDown(KeyCode.E)){

bacause the previous expression could return true when inRange == true and IsHolding and GetKey both were false.

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

5 People are following this question.

avatar image avatar image avatar image avatar image avatar image

Related Questions

how to get a animation from other script on colision 1 Answer

Pickup script not workimg 0 Answers

How to call animation from another Script in C#? 1 Answer

Animation problems 1 Answer

How to click a 3d object in unity3d? 3 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges