Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by fraubolat · May 25, 2020 at 03:58 PM · reloading

reload script not working well

when i reload the first time it works fine but after the first reload it increase from 4 to 8 and then from 8 to 16 here is the script

 using JetBrains.Annotations;
 using System.Collections;
 using System.Collections.Generic;
 using UnityEditor;
 using UnityEngine;
 
 public class shootingforshutgun : MonoBehaviour
 {
     public Transform ponit;
     public float Speed =10f;
     public GameObject bullet;
     bool canshot = false;
     int Bullets = 4;
     int currentbullet;
     bool reloading = false;
     void Start()
     {
         currentbullet = Bullets;
     }
 
     // Update is called once per frame
     void Update()
     {  
         if(currentbullet <= 0)
         {
             StartCoroutine(wait());
             return;
 
         }
 
 
 
        if(Input.GetButtonDown("Fire1"))
        {
             if (!canshot)
             {
                 A();
                 A();
                 A();
                 A();
                 currentbullet -= 1;
             }
 
                         
        }
 
         
     }
 
 
     public void A()
     {
         if (reloading)
             return;
         if (!canshot)
         {
             float x = Random.Range(-0.5f, 0.5f);
             float y = Random.Range(-0.5f, 0.5f);
             Vector3 a = new Vector3(x, y);
 
             Vector3 c = a + ponit.position;
             Instantiate(bullet, c, transform.rotation);
         }
     }
     IEnumerator wait()
     {
         yield return new WaitForSeconds(2f);
         currentbullet = Bullets;
         
     }
 
 }
 

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
1

Answer by KoenigX3 · May 25, 2020 at 04:10 PM

The problem is that you are starting new coroutines in every frame for about 2 seconds.

 void Update()
 {
    if(currentbullet <= 0 && !reloading)
    {
       StartCoroutine(wait());
       return;
    }
 }
 
 IEnumerator wait()
 {
    reloading = true;
    yield return new WaitForSeconds(2f);
    currentbullet = Bullets;
    reloading = false;
 }



I included the reloading variable so you can check it on Update. If you are already reloading, you don't need to start the coroutine again. When the reloading finishes, the currentbullet variable will be 4, and it will not reload again until you use the bullets.

Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image fraubolat · May 25, 2020 at 07:02 PM 0
Share

thank you very much

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

126 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

.Js Particle issue (probably easy for moderate coders) 0 Answers

Gun - Ammo , reloading and UI problem. 1 Answer

Fps game gun reloading problem 1 Answer

Reloading Function in Script not doing anything. 2 Answers

How can i save an entire scene when a checkpoint is hit 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges