Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by CoderBear · Apr 17, 2013 at 01:07 AM · c#audiosound effects

Can't get Sound working but music is fine

So I have the background music playing and hooray for that. However I can't get the one-shot sound effects to work as they are supposed to.

     public AudioClip caughtGood;
     public AudioClip caughtGold;
     public AudioClip caughtBad;
     public AudioClip combo_increased;
     
     ...
     void Start ()
     {
         ... // previous code    
         if((caughtBad != null || caughtGold != null || caughtGood != null || combo_increased != null) &&
             audio == null) {
             AudioSource source = gameObject.AddComponent<AudioSource>();
             source.playOnAwake = false;
         }
     }
 
    void PlaySound(AudioClip source) {
         if(audio && source) {
             audio.PlayOneShot(source);
         }
     }

Then I am calling for example:

 private void incrementCombo () {
     if (comboCount < 2) {
         comboCount++;
     } else {
         ...
         PlaySound(combo_increased);
         ...
     }
 }

Can someone please help me out. It is really weird why it won;t work.

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
1

Answer by iwaldrop · Apr 17, 2013 at 01:27 AM

There are a couple of things about your PlaySound method.

  1. You're passing a source, so you probably don't need to check that source is not null.

  2. PlayOneShot takes an AudioClip as an argument, not an AudioSource. (ref)

What you probably want to do in PlaySound is this:

 void PlaySound(AudioSource source)
 {
     source.Play();
 }

You may also want to set the AudioSource.loop variable to control the behavior of playing.

Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image iwaldrop · Apr 17, 2013 at 01:29 AM 0
Share

But then the question is...why even have a method that does that? Perhaps you should just call it in your original 'else' statement. :)

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

12 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Multiple Cars not working 1 Answer

Distribute terrain in zones 3 Answers

Sound plays right at the beginning 2 Answers

Problem with sound 0 Answers

Sound not working with onTriggerEnter 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges