Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
  • Help Room /
avatar image
0
Question by karmaral · Dec 27, 2017 at 10:07 AM · c#scripting problemupdate problemaccessor

I can access the field but it wont update the value?

Hey there. I'm having a rough time with this one.
I have a script that executes a method within its Update and returns a float. This is called angleDegrees, but it's private, so I made an accessor to be able to read from it externally, like so:

 public float angleDisplay
     {
         get
         {
             return angleDegrees;
         }
         set
         {
             angleDegrees = value;
         }
 
     }

(posting it just in case I might have messed up)
Then I proceed to call it from another script, by making another float field and accessing it on Start. I need it for a constant if check so it needs to be real time.

 lookAngle = GameObject.Find("Player").GetComponent<PlayerMouseLook>().angleDisplay;

Aaaand... well, it doesn't work. I'm not sure where I might be messing up. I checked the field (angleDegrees) in Debug mode and it does update in real time, lookAngle however remains unchanged. I also tried making angleDegrees public and accessing it, in case I was maybe screwing the accessor part, but it didn't work either.

If you could throw me a bone here I'd really appreciate it.
(oh and I didn't post the full code because it is a giant ball of mess but if you need it I can do so)
Cheers!

Comment
Add comment · Show 1
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image TreyH · Dec 27, 2017 at 12:33 PM 0
Share

Your wording is indicating some confusion in how these things work, so I'd like to clarify your problem.


Then I proceed to call it from another script, by making another float field and accessing it on Start


So are you accessing and storing a reference to the field in the Start() function and trying to manipulate it later? If that's the case, you are going to have problems as Unity's supported versions of .NET do not yet support value references being stored as variables.


Have you tried storing a reference to your Component script and editing the value of its field?

3 Replies

· Add your reply
  • Sort: 
avatar image
0
Best Answer

Answer by karmaral · Dec 27, 2017 at 05:32 PM

Somehow I can't see your comment so I'll quote it from the e-mail notification lol

@TreyH

By "in real time", are you editing the value in Update() on another script?

In script 1, I have angleDegrees which is the return of a method that runs in Update().

Script 2 holds lookAngle, which is needed as a read-only to calculate something else, also in real time, but it is assigned in Start() and attempting to fetch it from script 2 doesn't work.

Now, if I sort of 'override' lookAngle from script 1 towards script 2, this works.

Actually I think I might be onto the problem here. I assumed that the 'updatey' nature of angleDegrees was inherited automatically inside the other script, and thus lookAngle would update in realtime aswell. This is not the case, right? Assigning it on Start only applies it... on start. But then how should I turn the functionality to work inside of Update()?

Should I just call
lookAngle = GameObject.Find("Player").GetComponent<PlayerMouseLook>().angleDisplay;

in Update()? It seems rather messy...

Comment
Add comment · Show 3 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image TreyH · Dec 27, 2017 at 06:06 PM 1
Share

Just store the component reference ahead of time.

 // $$anonymous$$eep a reference to the target Player$$anonymous$$ouseLook
 private Player$$anonymous$$ouseLook player$$anonymous$$ouse;
 
 // Use this for initialization
 void Start()
 {
     this.player$$anonymous$$ouse = GameObject.Find("Player").GetComponent<Player$$anonymous$$ouseLook>();
 }
 
 // Update is called once per frame
 void Update()
 {
     Debug.Log(this.player$$anonymous$$ouse.angleDisplay);
 }
avatar image karmaral TreyH · Dec 27, 2017 at 06:44 PM 0
Share

Right, I had thought of that earlier on but ended up discarding it because it wasn't working (I was missing the Update part)

Thank you!

avatar image TreyH karmaral · Dec 27, 2017 at 06:47 PM 0
Share

Great! If this has answered your problem, please convert the comment to an answer and mark it as the solution. That way we can close the thread and mark this problem as solved.

avatar image
1

Answer by ransomink · Dec 27, 2017 at 11:33 PM

The problem is, you're accessing angleDisplay in Start(). Start is called only once and before any Update method runs, so this will grab its current value at the start of the script (and never again). If angleDegrees gets updated every frame you'll have to grab it via accessor every frame as well.


You need to make a reference to the PlayerMouseLook script, then access the angleDisplay when you need lookAngle updated. Also, use FindGameObjectWithTag("Player") instead of Find(), it's less expensive.


 public class PlayerMouseLook : MonoBehaviour
 {
     [SerializeField] float angleDegrees;
 
     public float AngleDisplay
     {
         get { return  angleDegrees; }
         set { angleDegrees = value; }
     }
 }


 public class OtherScript : MonoBehaviour
 {
     PlayerMouseLook mouseLook;
     float lookAngle;
 
     void Awake()
     {
         mouseLook = GameObject.FindGameObjectWithTag( "Player" ).GetComponent<PlayerMouseLook>();
     }
 
     void Update()
     {
         lookAngle = mouseLook.AngleDisplay;
     }
 }


I used PascalCase for my accessor, so note the difference between your file. Most accessors are created this way because they typically carry the same name as the variable they contain. It also allows you to easily differentiate between a regular variable and a property...

Comment
Add comment · Show 3 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image karmaral · Dec 28, 2017 at 02:27 AM 0
Share

Thank you, valuable information indeed, I appreciate it!

avatar image ransomink karmaral · Dec 28, 2017 at 11:08 AM 0
Share

Were you able to fix it now?

avatar image karmaral ransomink · Dec 28, 2017 at 11:51 AM 0
Share

Yes! I had marked it as answered already earlier on, does it not appear like so? The site's been working a bit funky for me lately...

avatar image
0

Answer by karmaral · Dec 27, 2017 at 11:37 AM

Okay, I found that if I set the field from the original script to override lookAngle, it works and updates in real time, but I'd like to be able to access it the other way around since I feel it's not the most elegant solution coding-wise. Could there be a workaround for this situation?

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

439 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

I want my script to wait 2 seconds before continue in a condition, in update, using C# 2 Answers

PLEAASEE I NEED HELP!!! How to turn Mesh Renderer of cubes on and off by pushing buttons? 1 Answer

videoPlayer Script Help Needed 0 Answers

Enabling & Disabling Script via On Click 1 Answer

Add 2D Skeleton to the Scene if Button was pressed 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges