koobas.hobune.stream
Editor GUILayout.ScrollView not scrolling when typing
I am having a rather frustrating time with ScrollViews. Here's a snippet from my custom editor that should be enough to reproduce the problem.
EditorGUILayout.BeginVertical();
scrollPosition = GUILayout.BeginScrollView (scrollPosition);
_target.text = EditorGUILayout.TextArea(_target.text, style);
GUILayout.EndScrollView ();
EditorGUILayout.EndVertical ();
The problem is that when I give a few carriages so that the scroll bars appear, the scrolling does not follow the typing and I cannot see what I type.
Any ideas?
Hi @Rs. That's super annoying! Would you mind filing a bug report please? In the meantime you can do something like this (though it's a little naive):
EditorGUILayout.BeginVertical();
scrollPosition = EditorGUILayout.BeginScrollView (scrollPosition);
EditorGUI.BeginChangeCheck ();
string newText = EditorGUILayout.TextArea(_target.text);
if (EditorGUI.EndChangeCheck ())
{
if (newText.StartsWith (_target.text))
scrollPosition.y = Mathf.Infinity;
_target.text = newText;
}
EditorGUILayout.EndScrollView ();
EditorGUILayout.LabelField (scrollPosition.ToString ());
EditorGUILayout.EndVertical ();
Setting the y to $$anonymous$$athf.Infinity? :D I LI$$anonymous$$E THAT!
It's also quite clever to check if the text has changed in the end that way. The thing is that StartsWith does a full string comparison, I can't really do that in an asset I'm selling. Isn't there a way to know where the text cursor is? $$anonymous$$aybe I'm wrong but I kind of remember some API of that kind.
I posted on your other question. You could try manually walking like this (I've put both methods in so you can profile and compare performance):
scrollPosition = EditorGUILayout.BeginScrollView (scrollPosition);
EditorGUI.BeginChangeCheck ();
string newText = EditorGUILayout.TextArea (targetText);
if (EditorGUI.EndChangeCheck ())
{
string shorter, longer;
if (newText.Length > targetText.Length)
{
shorter = targetText;
longer = newText;
}
else
{
shorter = newText;
longer = targetText;
}
UnityEngine.Profiling.Profiler.BeginSample ("STARTSWITH", this);
bool changedAtEnd = longer.StartsWith (shorter);
UnityEngine.Profiling.Profiler.EndSample ();
UnityEngine.Profiling.Profiler.BeginSample ("$$anonymous$$ANUALLY WAL$$anonymous$$", this);
changedAtEnd = true;
for (int i = shorter.Length - 1; i >= 0; --i)
{
if (shorter[i] != longer[i])
{
changedAtEnd = false;
break;
}
}
UnityEngine.Profiling.Profiler.EndSample ();
if (changedAtEnd)
scrollPosition.y = $$anonymous$$athf.Infinity;
targetText = newText;
}
EditorGUILayout.EndScrollView ();
