Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by rpp1011 · Dec 17, 2017 at 09:20 PM · scripting problemeditor-scripting

SerializedProperty.animationCurveValue cannot be set directly

Assigning a value to the animationCurveValue property of an instance of the SerializedProperty class will cause an error stating that the value that is being assigned is not an animation curve even if it is. How can I fix or circumvent this?


Containing class

 [CustomPropertyDrawer(typeof(SerializedAnimationCurve))]
 public class CustomCurveDrawer : PropertyDrawer
 {
     public override void OnGUI(Rect position, SerializedProperty property, GUIContent label)
     {
         EditorGUI.BeginProperty(position, label, property);
 
         var amountRect = new Rect(position.x, position.y + EditorGUIUtility.singleLineHeight, position.width, position.height);
         var curveRect = new Rect(position.x - position.width, position.y + EditorGUIUtility.singleLineHeight, position.width, position.height);
 
         SerializedProperty templateCurveProperty = property.FindPropertyRelative("template");
         SerializedProperty curveProperty = property.FindPropertyRelative("curve");
 
         EditorGUI.PropertyField(new Rect(position.x, position.y, position.width - 6, 15), curveProperty, label);
 
         Rect indentRect = EditorGUI.IndentedRect(position);
 
         Object templateValue = templateCurveProperty.objectReferenceValue;
 
         EditorGUI.PropertyField(new Rect(indentRect.x + 15, indentRect.y + 20, indentRect.width - 21, 15), templateCurveProperty, new GUIContent("Template"));
         if (templateValue != templateCurveProperty.objectReferenceValue)
         {
             SerializedObject serializedObject = new SerializedObject(templateCurveProperty.objectReferenceValue);
 
             AnimationCurve templateCurve = ((SerializableAnimationCurveObject)templateCurveProperty.objectReferenceValue).curve;
             SerializedProperty objCurveProperty = serializedObject.FindProperty("curve");
 
             //Debug.Log(templateCurve);
             //Debug.Log(serializedObject.FindProperty("curve").animationCurveValue);
 
             objCurveProperty.animationCurveValue = templateCurve;
             serializedObject.ApplyModifiedProperties();
         }
         EditorGUI.EndProperty();
     }
     public override float GetPropertyHeight(SerializedProperty prop, GUIContent label)
     {
         float extraHeight = 25f;
         return base.GetPropertyHeight(prop, label) + extraHeight;
     }
 }


Referenced Classes

 [System.Serializable]
 [CreateAssetMenu(fileName = "AnimCurve", menuName = "Curve")]
 public class SerializableAnimationCurveObject : ScriptableObject
 {
     public string curveName;
 
     public AnimationCurve curve;
 
     private void OnEnable()
     {
         curveName = name;
     }
 
     public static implicit operator AnimationCurve(SerializableAnimationCurveObject serializableCurve)
     {
         return serializableCurve.curve;
     }
 
     public static implicit operator SerializedAnimationCurve(SerializableAnimationCurveObject serializableCurve)
     {
         return new SerializedAnimationCurve(serializableCurve);
     }
 }
 
 [System.Serializable]
 public class SerializedAnimationCurve
 {
     public string curveName;
     public AnimationCurve curve;
     public SerializableAnimationCurveObject template;
 
     public SerializedAnimationCurve(SerializableAnimationCurveObject template)
     {
         this.template = template;
         curveName = template.curveName;
         curve = template.curve;
     }
 }


Problem snippet

 SerializedObject serializedObject = templateCurveProperty.serializedObject;
             AnimationCurve templateCurve = ((SerializableAnimationCurveObject)templateCurveProperty.objectReferenceValue).curve;
             SerializedProperty objCurveProperty = serializedObject.FindProperty("curve");
 
             Debug.Log(templateCurve);
             Debug.Log(serializedObject.FindProperty("curve").animationCurveValue);
 
             objCurveProperty.animationCurveValue = templateCurve;
             serializedObject.ApplyModifiedProperties();



Prints the following statements circumvent

capture.png (12.0 kB)
Comment
Add comment · Show 2
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Adam-Mechtley · Dec 17, 2017 at 09:26 PM 0
Share

What do you get if you log objCurveProperty.propertyType?

avatar image rpp1011 Adam-Mechtley · Dec 17, 2017 at 09:29 PM 0
Share

It prints "Generic"

1 Reply

· Add your reply
  • Sort: 
avatar image
1
Best Answer

Answer by Adam-Mechtley · Dec 17, 2017 at 09:54 PM

Based on your response above, the problem is that you are trying to set animationCurveValue on a serialized property that does not actually refer to an animation curve.

It's hard to say without more context, but from your example it looks like SerializableAnimationCurveObject is a ScriptableObject. If that's the case, you need to get a separate serialized data stream for it. Something like this:

 var templateSO = new SerializedObject(templateCurveProperty.objectReferenceValue);
 var curveProperty = templateSO.FindProperty("curve");
 curveProperty.animationCurveValue = templateCurve;
 templateSO.ApplyModifiedProperties();
Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image rpp1011 · Dec 17, 2017 at 10:26 PM 0
Share

Thanks for the help.

Final code ended up being

 AnimationCurve templateCurve = ((SerializableAnimationCurveObject)templateCurveProperty.objectReferenceValue).curve;
             var templateSO = new SerializedObject(templateCurveProperty.objectReferenceValue);
             var actualCurve = templateSO.FindProperty("curve");
             curveProperty.animationCurveValue = actualCurve.animationCurveValue;
             curveProperty.serializedObject.Apply$$anonymous$$odifiedProperties();

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

133 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

How to create gameObjects in editor mode 1 Answer

How can i add a second camera that will be showing only specific gameobject in game window ? 1 Answer

Custom UnityEvent in Editor Window 1 Answer

ExecuteInEditMode not working in some scripts 1 Answer

Unity external script editor won't change 6 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges