Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by thexoy · Jun 18, 2019 at 04:49 PM · audiofunctionbooleanaudioclipmusic

Music will not change when an event triggers it

Cannot get my music to change when a boolean changes from false to true. The boolean is definitely changing, but the code itself is not activating the new track. Any ideas what may be causing this?

 public class AudioManager : MonoBehaviour
 {
     public AudioSource BGM;
     public AudioClip goTrack;
     public bool gameOver = false;
 
     void ChangeBGM(AudioClip music)
     {
         music = goTrack;
 
         if(gameOver == true)
         {
             Debug.Log("Playing Game Over Music");
             BGM.Stop();
             BGM.clip = goTrack;
             BGM.Play();
         }
 
     }
 }
Comment
Add comment · Show 3
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Hellium · Jun 18, 2019 at 04:56 PM 0
Share

When is called ChangeBG$$anonymous$$? Who calls it?

A very strange thing I don't understand is the following line:

 music = goTrack;

Shouldn't it be

 goTrack = music;

???

avatar image thexoy Hellium · Jun 18, 2019 at 06:53 PM 0
Share

You are definitely correct, but unfortunately that did not make it work.

avatar image Hellium thexoy · Jun 18, 2019 at 07:44 PM 0
Share

How about my 2 questions?

Do you see only one Playing Game Over $$anonymous$$usic in the console? (make sure the Collapse button is not turned on in the Console tab)

3 Replies

· Add your reply
  • Sort: 
avatar image
0
Best Answer

Answer by Spip5 · Jun 18, 2019 at 07:36 PM

@thexoy I'd suggest you create a singleton Instance for that AudioManager to get rid of this boolean.

 public static AudioManager Instance;
 
 void Awake() {
 if (AudioManager.Instance) {
 destroy(this);
 } else {
 Instance = this;
 }

and then you call a function tho change your song

 public void PlayGameOverSong() {
              BGM.Stop();
              BGM.clip = goTrack;
              BGM.Play();
 }

from another script with something like this

 void ExternalFunction() {
 AudioManager.Instance.PlayGameOverSong();
 }

Hope that helps

Edit : To properly answer your question : a function isn't re-called unless you call it (except for Updates which is called every frame but can be a CPU eater if wrongly used). Changing your bool won't re-call your function., you would have to change the bool THEN re-call the function. Therefore your bool is not really necessary, just do a function that changes your song (see above).

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image
1

Answer by PolyvivalStudios · Jun 18, 2019 at 07:17 PM

Are you calling the function from another script? It won't work otherwise. Or If you want it to check if the boolean is true or false all the time, put it in the update function.

@thexoy

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image
1

Answer by TeriakiGames · Jun 18, 2019 at 08:01 PM

@thexoy

So the way an audio source work, is that it plays the sound when you want it to.

If you really want it to be successful. Try adding

Audio.stop(); Audiosource.clip = to your clip;

// Add line here if (audiosource.isPlaying() == false) { //Then play you`r tune. Audiosource.play();

}

Also check in the inspector to see if it is changing??.

Hope this helps

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

147 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

AudioClip Precise Timing and Delay 1 Answer

Sound issues 0 Answers

How to stop music from restarting when reloading scene it began? 0 Answers

Problem with enabling and playing audios 0 Answers

C sharp cant play Audio 2 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges