Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by inigopanos · Apr 28, 2020 at 01:44 PM · scripting problemscripting beginner

Infinite repetition, need help

Hey guys, I want to make an enemy activate a Bang! sprite using a Random.Range, but i've fallen into a infinte loop I'm unable to break out of. Any help is appreciated. I am using IEnumerators to do it, I think its the right way but I'm not sure.

using System.Collections; using System.Collections.Generic; using UnityEngine;

public class DisparoEnemigo : MonoBehaviour {
public GameObject Bang;

 [Range(0f, 10f)]
 public float minTime = 2f;
 [Range(0f, 10f)]
 public float maxTime = 4f;
 
 public float counter;

 public bool bangActivo = false;
   


 void Start()
 {   
     counter = 5f;
 }

 void Update()
 {
     //Debug.Log(counter);
     counter -= Time.deltaTime;

     if (counter <= 0f)
     {
         //Prueba();

         StartCoroutine(EsperarAlBang());
         Debug.Log("if() 1 completado");
         //counter = -1f;
     }

     if (bangActivo == true)
     {      
         StartCoroutine(FueraBang());
         Debug.Log("If() 2 completado");
     }        
 }

IEnumerator EsperarAlBang() { yield return new WaitForSeconds(Random.Range(minTime, maxTime)); Bang.SetActive(true); Debug.Log("BangActivo true"); bangActivo = true; //Debug.Log("Ienumerator 1 completado"); }

IEnumerator FueraBang() { yield return new WaitForSeconds(5f); Bang.SetActive(false); bangActivo = false; counter = 5f; Debug.Log("Ienumerator 2 completado"); }

 void Prueba()
 {

 }

}

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
0

Answer by yummy81 · Apr 28, 2020 at 02:53 PM

I reproduced your logic in one big coroutine. I think it is much cleaner, and hope it is what you want.

Regarding your code, you do not reset the counter, when it goes below 0f. You do it, but much later (far too late) in the second coroutine. With each frame counter falls deeper and deeper into negative territory, and as it is the condition of starting coroutine - with each frame starts new coroutine. Here's the script:

 using System.Collections; 
 using System.Collections.Generic; 
 using UnityEngine;
 
 public class DisparoEnemigo : MonoBehaviour {
     
     public GameObject Bang;
 
     [Range(0f, 10f)]
     public float minTime = 2f;
     [Range(0f, 10f)]
     public float maxTime = 4f;
 
     float counter;
     bool boo;
 
     void Start()
     {   
         counter = 5f;
         boo = true;
     }
     
     void Update(){
         if (boo){
             StartCoroutine(OneBigCoroutine());            
         }
     }
 
     IEnumerator OneBigCoroutine(){
         boo = false;
         
         yield return new WaitForSeconds(counter);
 
         yield return new WaitForSeconds(Random.Range(minTime, maxTime)); 
         Bang.SetActive(true); 
 
         yield return new WaitForSeconds(5f); 
         Bang.SetActive(false); 
         
         boo = true;
     }    
 }
Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

231 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Player alignment with Terrain 1 Answer

Question regarding Raycast hitting UI button object instead of gameobject 0 Answers

Script executing through walls 1 Answer

If-else statement executing incorrectly in foreach loop,why? 0 Answers

Point Counter Works Only Once! 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges