Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
-1
Question by willaay96 · Sep 13, 2017 at 02:19 PM · coroutineienumerator

IEnumerator not waiting before relooping.

I have an enemy who in the update fires projectiles at the player if in range every X seconds however he never waits between shots. I've checked with the print statements that the projectile is fired multiple times before the WaitForSeconds happens. Can someone explain what I've done wrong.

 if (distanceToPlayer <= attackRange)
 {
     aiCharControl.agent.isStopped = true;
     anim.SetFloat("BlendY", 0);
     //Fire or Attack
     StartCoroutine(FireProjectile(target));
 }

 private IEnumerator FireProjectile(Transform target)
 {

     GameObject projectile = Instantiate(projectileToUse, projectileSpawnPoint.position, Quaternion.identity) as GameObject;
     Projectile projComponent = projectile.GetComponent<Projectile>();
     float projSpeed = projComponent.Speed;
     Vector3 distanceToPlayer = (target.transform.position - projectileSpawnPoint.transform.position).normalized;
     projectile.GetComponent<Rigidbody>().velocity = distanceToPlayer * projSpeed;
     projectile.transform.LookAt(target);
     projComponent.Damage = projectileDamage;
     print(Time.time + " Before wait");
     yield return new WaitForSeconds(timeBetweenShots);
     print(Time.time + " After wait");
 }





Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
1
Best Answer

Answer by GenericToast · Sep 13, 2017 at 02:28 PM

I assume you are checking if (distanceToPlayer <= attackRange) in an Update loop, this means StartCoroutine(FireProjectile(target)); is being called multiple times so the projectile is shot multiple times.

What you can do is have a bool canShoot variable and change it so that the coroutine is only called when canShoot is true

  if (distanceToPlayer <= attackRange)
  {
      aiCharControl.agent.isStopped = true;
      anim.SetFloat("BlendY", 0);
      //Fire or Attack
      if(canShoot)
          StartCoroutine(FireProjectile(target));
  }

In your FireProjectile coroutine add in a line that sets canShoot to false, and set it back to true after the WaitForSeconds is finished

  private IEnumerator FireProjectile(Transform target)
  {
      //All your previous code here

      //New line of code here
      canShoot = false;

      print(Time.time + " Before wait");
      yield return new WaitForSeconds(timeBetweenShots);
      print(Time.time + " After wait");

      canShoot = true;
  }

Hope this helps

Comment
Add comment · Show 2 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image NoseKills · Sep 13, 2017 at 03:04 PM 0
Share

To clarify to the OP: you create a new coroutine over a new IEnumerator every time you call StartCoroutine(FireProjectile(target));

You have no more lines of code after your yield new WaitForSeconds() so there is no code that would get delayed by it. All of the code in the IEnumerator is executed as soon as you start the brand new coroutine.

IEnumerators/CoRoutines don't loop (as you suggest in the title) unless you really have a loop in it.

avatar image willaay96 · Sep 13, 2017 at 03:12 PM 0
Share

ah thank you both, I was viewing it as a sort of loop that goes "do everything until the yield return, then waitforseconds". So it would only "reloop" after its waited for that amount of time.

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

74 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

How to make loop with call to IEnumerator actually pause? 2 Answers

WaitForSeconds Not Working 4 Answers

Problem with coroutine 2 Answers

How Return Or Restart A Coroutine When A Variable Increase? 0 Answers

What can cause a coroutine to not being working? 9 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges