koobas.hobune.stream
Why simple letter evaluataion returns true no matter witch letter
Hi,
I have a coroutine that runs through letters in a string and evaluates each to check if the letter is a dot, question mark or exclamation point and if the last letter was not any of those. The problem is that the evaluation returns true no matter what character it is evaluating.
char[] validStopLetters = { '.', '!', '?' };
if (letter == validStopLetters[0] | letter == validStopLetters[1] | letter == validStopLetters[2] & lastLetter != validStopLetters[0] | lastLetter != validStopLetters[1] | lastLetter != validStopLetters[2])
{
audioManager.Stop("Typing");
typingStopped = true;
yield return new WaitForSeconds(1);
}
else
{
yield return new WaitForSeconds(typingSpeed);
}
Thanks in advance for any explanation :)
Try this
char[] validStopLetters = { '.', '!', '?' };
if ((letter == validStopLetters[0] || letter == validStopLetters[1] || letter == validStopLetters[2]) && (lastLetter != validStopLetters[0] && lastLetter != validStopLetters[1] && lastLetter != validStopLetters[2]))
{
audioManager.Stop("Typing");
typingStopped = true;
yield return new WaitForSeconds(1);
}
else
{
yield return new WaitForSeconds(typingSpeed);
}
Notice the ( and ) around first 3 comparisions, separating it from the last 3 (also have parenthesis around them). Notice to the double || and double &&.
What you where asking in your if was: if some of this is true, then :
letter == validStopLetters[0]
letter == validStopLetters[1]
letter == validStopLetters[2] & lastLetter != validStopLetters[0]
lastLetter != validStopLetters[1]
lastLetter != validStopLetters[2] Obviously, at least one of the last 2 would be true, so you always get TRUE.
Oh, sorry! I didn't notice the extra parentheses, this worked! Thanks!
Also, I noticed that the last 3 comparisions are irrelevant. You have to put && ins$$anonymous$$d of ||. I modify the answer.
