Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by Kharief · Oct 20, 2016 at 01:16 PM · audioaudiosourceshootinggun script

Audio repeats

hello i am having a problem with my gun . When i shoot it the audio is being repeated when i click the shoot button rather than being continued. Please help

 public enum GunType { Semi, Burst, Auto };
 public GunType gunType;
 public float rpm;

 // Components
 public Transform spawn;
 private LineRenderer tracer;

 // System:
 private float secondsBetweenShots;
 private float nextPossibleShootTime;

 void Start() {
     secondsBetweenShots = 60 / rpm;
     if (GetComponent<LineRenderer>())        {
         tracer = GetComponent<LineRenderer>();
     }
 }

 public void Shoot()  {

     if (CanShoot())
     {
         Ray ray = new Ray(spawn.position, spawn.forward);
         RaycastHit hit;

         float shotDistance = 20;

         if (Physics.Raycast(ray, out hit, shotDistance))
         {
             shotDistance = hit.distance;
         }

         nextPossibleShootTime = Time.time + secondsBetweenShots;

         GetComponent<AudioSource>().Play();

         if (tracer)  {
             StartCoroutine("RenderTracer", ray.direction * shotDistance);
         }
     }

 }

 public void ShootContinuous()  {
     if (gunType == GunType.Auto) {
         Shoot ();
     }
 }

 private bool CanShoot() {
     bool canShoot = true;

     if (Time.time < nextPossibleShootTime) {
         canShoot = false;
     }

     return canShoot;
 }

 IEnumerator RenderTracer(Vector3 hitPoint)    {
     tracer.enabled = true;
     tracer.SetPosition(0, spawn.position);
     tracer.SetPosition(1, spawn.position + hitPoint);

     yield return null;
     tracer.enabled = false;
 }

}

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

3 Replies

· Add your reply
  • Sort: 
avatar image
0

Answer by Sageose · Oct 20, 2016 at 02:44 PM

I'm not sure, but you might want to try

 GetComponent<AudioSource>().PlayOneShot();

instead of

 GetComponent<AudioSource>().Play();

If not, is the audio clip only one shot or is it a continuous shooting sound?

Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Kharief · Oct 20, 2016 at 10:48 PM 0
Share

continuous shooting

avatar image
0

Answer by PeteD · Oct 20, 2016 at 02:44 PM

@Kharief

I'm not sure I understand what you mean by

When i shoot it the audio is being repeated when i click the shoot button rather than being continued.

this line

GetComponent().Play();

Will start the sound again from the beginning. To pause and resume the audio from it's current position you would need to enable and disable the audiosource instead of using play and stop.

Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Kharief · Oct 20, 2016 at 10:45 PM 0
Share

i mean that when i click to shoot the audio is being replayed

avatar image
0

Answer by Kharief · Oct 21, 2016 at 07:27 AM

@PeteD

@Sageose

i made a video about my problem here : https://www.youtube.com/watch?v=1NzSF33t8fs&feature=youtu.be

Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image PeteD · Oct 21, 2016 at 08:43 AM 0
Share

If all you want is to stop the audio restarting if it's already playing then something like the code below will work

 AudioSource audio = GetComponent<AudioSource>();
 
 if( ! audio.isPlaying )
 {
 audio.Play();
 }

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

5 People are following this question.

avatar image avatar image avatar image avatar image avatar image

Related Questions

audio loop when I click the MouseButtonDown(0) 1 Answer

AudioHighPassFilter with multiple AudioSource 1 Answer

Global audio option 2 Answers

Audio loops too early 2 Answers

Playing Sound 2 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges