Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
  • Help Room /
avatar image
0
Question by tal193 · Sep 05, 2018 at 06:39 AM · collisiongameobjectssetactivetutorials

issues with other.gameObject.SetActive(false);

I'm following the Space Shooter tutorial but I'm trying to change the script for the explosions to just collecting the Asteroid. I have no errors in the script but the Asteroid does not disappear with it Collides with my spaceship and the score keeps adding points soon as an Asteroid comes into frame.

If anyone can provide me a hint on where I am wrong please do let me know!

using System.Collections; using System.Collections.Generic; using UnityEngine; using UnityEngine.UI;

public class Collect: MonoBehaviour {

 public int scoreValue;
 private Done_GameController gameController;


 void Start ()
 {
     GameObject gameControllerObject = GameObject.FindGameObjectWithTag ("GameController");
     if (gameControllerObject != null)
     {
         gameController = gameControllerObject.GetComponent <Done_GameController>();
     }
     if (gameController == null)
     {
         Debug.Log ("Cannot find 'GameController' script");
     }
 }
 void OnTriggerEnter (Collider other)
 {
     //Check the provided Collider2D parameter other to see if it is tagged "PickUp", if it is...
     if (other.gameObject.CompareTag("Enemy"))

     //... then set the other object we just collided with to inactive.
     other.gameObject.SetActive(false);

             gameController.AddScore(scoreValue);

     //Add one to the current value of our count variable.
         }

     }
Comment
Add comment · Show 1
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Hellium · Sep 05, 2018 at 07:33 AM 0
Share

I think you have missed the braces under the if statement.

 if (other.gameObject.CompareTag("Enemy"))
 { // here
      //... then set the other object we just collided with to inactive.
      other.gameObject.SetActive(false);
      //Add one to the current value of our count variable.
      gameController.AddScore(scoreValue);
 } // here

Also, make sure the other gameObject is correctly tagged Enemy in the editor

1 Reply

· Add your reply
  • Sort: 
avatar image
-1

Answer by tormentoarmagedoom · Sep 05, 2018 at 09:13 AM

Good day.

You need to detect "strange things".

Look at line 25, you see the code is moved to right? this is because there is something strange, your scripting program detects something is wrong with "squematic" symbols like ( ) or { } or [ ] ..

So if you check it will see your if sentence from line 20 have nothing inside, because you did not put any "{...}"

And the code thinks the lines 24 and 25 are not inside that if...

Good bye!

Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Hellium · Sep 05, 2018 at 09:45 AM 0
Share

Yes, the if statement contains the statement line 24. The comment is not taken into account by the compiler, nor the identation.

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

208 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Cycle through objects on mouse click 1 Answer

GameObject - SetActive not working 1 Answer

Script in C sharp collision when entered fires arrows at player 0 Answers

Unity - creating a breakout style game - ball will not destroy blocks or be reset 0 Answers

I got a bunch of problems and i don't know how to fix them! 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges