- Home /
Question by
toxicnoodleyt · Feb 22, 2020 at 01:59 AM ·
shadershadersshader programming
My shader code is having an error with returns at lines 50 and 60.
Shader "PeerPlay/NewImageEffectShader"
{
Properties
{
_MainTex ("Texture", 2D) = "white" {}
}
SubShader
{
// No culling or depth
Cull Off ZWrite Off ZTest Always
Pass
{
CGPROGRAM
#pragma vertex vert
#pragma fragment frag
#pragma target 3.0
#include "UnityCG.cginc"
sampler2D _MainTex;
uniform float4 _CamWorldSpace;
uniform float4x4 _CamFrustum, _CamToWorld;
struct appdata
{
float4 vertex : POSITION;
float2 uv : TEXCOORD0;
};
struct v2f
{
float2 uv : TEXCOORD0;
float4 vertex : SV_POSITION;
float3 ray : TEXTCOORD1;
};
v2f vert (appdata v)
{
v2f o;
half index = v.vertex.z;
v.vertex.z = 0;
o.vertex = UnityObjectToClipPos(v.vertex);
o.uv = v.uv;
o.ray = _CamFrustum[(int)index].xyz;
o.ray /= abs(o.ray.z);
o.ray = mul(_CamToWorld, o.ray)
return o;
};
fixed4 frag (v2f i) : SV_Target
{
float3 rayDirection = normalize(i.ray.xyz);
float3 rayOrigin = _CamWorldSpace;
return fixed4(rayDirection, 1);
};
ENDCG
}
}
}
Comment
Answer by Namey5 · Feb 22, 2020 at 09:50 AM
At line 35;
float3 ray : TEXTCOORD1;
should be;
float3 ray : TEXCOORD1;
The returns are still not working even after the fix.
There's also two problems with line 48;
o.ray = mul(_CamToWorld, o.ray)
You're missing a semi-colon and the matrix multiplication is between incompatible types (float4x4 and float3).
Your answer
Follow this Question
Related Questions
perform action on shader compilation/update 0 Answers
Shader Problem 0 Answers
Stretching when using world coordinates 2 Answers
Shader: How to write a shader that respects sorting order first and then depth 1 Answer
Referencing the current pixel's world coordinates in the SURF block of a shader 1 Answer