Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by amag02 · Dec 26, 2016 at 09:33 PM · instantiateloopforeachbreak

Instantiate inside foreach loop

Hello all! This is my first time using Unity, and I've run into quite a bugger trying to instantiate a prefab into UI. Everything works as it should when I have the instantiate line commented out, however when I attempt to run the instantiate command it stops the foreach loop and does not continue to run it for the other objects. For example, inside the loop is code that will prevent game objects from falling out of view, however they will fall once the instantiate function is called. uidListOS is a list that records all objects on screen.

         GameObject[] allDragables;
         allDragables = GameObject.FindGameObjectsWithTag("dragable");
         foreach(GameObject obj in allDragables){
             string objName = obj.name;
             Vector3 v = obj.transform.GetComponent<Rigidbody2D>().velocity;
             if (obj.activeInHierarchy){
 
                 //In Bounds
                 if (cam.WorldToViewportPoint(obj.transform.position).y <= 1.05){
                     if (uidListOS.Contains(objName) == false){
                         //destroyDistBox(objName);
                         writeToConsole("Back On screen; Only called once");
                         uidListOS.Add(objName);
                         
                     }
                 }
 
                 //Upper Bound
                 if (cam.WorldToViewportPoint(obj.transform.position).y > 1.05){
                     if (uidListOS.Contains(objName)){ //Just went off screen
                         createDistBox(objName); //contains instantiate func
 
                         uidListOS.Remove(objName);
                     }
                     else
                     { //Remaining off screen
                         updateDistBox(obj.name.ToString());
                     }
                 }
 
 
 .......


And the function containing instantiate...

     void createDistBox(string objId){
         writeToConsole("Object " + objId.ToString() + " just off screen");
         string _boxName;
         GameObject box;
         _boxName = objId + "box";
         box = (GameObject)Instantiate(uiPrefab);//<--Issue
         box.transform.SetParent(GameObject.Find("Canvas").transform, false);
         box.name = _boxName;
     }
Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
0

Answer by AurimasBlazulionis · Dec 26, 2016 at 10:21 PM

Check the console for errors. Probably you haven't attached the prefab. Also, NEVER EVER user GameObject.Find in loops.

Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image amag02 · Dec 27, 2016 at 04:47 PM 0
Share

I'm compiling to android, so I have my own output on a basic onscreen console. That being said, there are no errors on the console. As for the GameObject.Find, what is an alternative?

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

6 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Foreach loop wont run completely 3 Answers

Is having a "break" in a "foreach" loop that is itself inside a "for" loop breaking both loops? 3 Answers

Instantiate for loop skips some objects 1 Answer

Why is there a difference between script and in-game sequence of a script loop? 1 Answer

Unity Freezing 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges