Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by justinkatic · Sep 22, 2017 at 05:01 AM · damagenewbiehealthbarhealth

Health Bar going 0 right away

not sure what I'm missing so got character taking damage and the print statements come up just fine when hit 80-60-40-20-0 (dead) etc but my health bar when I take the first hit it just instantly drops to 0.

heres the code I'm using any help would be amazing.

using System.Collections; using System.Collections.Generic; using UnityEngine; using UnityEngine.UI;

public class DamageScript : MonoBehaviour { public int currentHealth = 100; public int maxHealth = 100; int damage = 20; public Image currentHealthBar; public Text ratioText;

 void Start()
 {
     maxHealth = 100;
     currentHealth = maxHealth;
     UpdateHealthbar ();
 }
 public void UpdateHealthbar()
 {
     int ratio = currentHealth / maxHealth;
     currentHealthBar.rectTransform.localScale = new Vector3 (ratio, 1, 1);
     ratioText.text = (ratio * 100).ToString ("0") + '%';
 }
 void OnCollisionEnter (Collision col)
 {
     if (col.gameObject.tag == "Bullet") {
         currentHealth -= damage;
         print ("hurt" + currentHealth);
         if (currentHealth <= 0)
             Destroy (gameObject);
         {
             UpdateHealthbar ();

         
     } if (col.gameObject.tag == "Enemy") {
         currentHealth -= damage;
         UpdateHealthbar ();
         print ("hurt" + currentHealth);
         if (currentHealth <= 0)
             Destroy (gameObject);
     }
     
 }

} }

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
1
Best Answer

Answer by vadithiyan · Sep 22, 2017 at 05:27 AM

@justinkatic Use float for ratio, using an int and dividing will give you integer values rounded to the lower integer number. For example : int ratio = 80/100 will be 0.

  public void UpdateHealthbar()
  {
      float ratio = currentHealth / maxHealth;
      currentHealthBar.rectTransform.localScale = new Vector3 (ratio, 1, 1);
      ratioText.text = (ratio * 100).ToString ("0") + '%';
  }

Change UpdateHealthBar script to this.

Comment
Add comment · Show 2 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image justinkatic · Sep 22, 2017 at 05:33 AM 0
Share

thanks make sense still dropping to 0 though after that change :(

avatar image justinkatic · Sep 22, 2017 at 05:42 AM 0
Share

nm got it I had to change current heath and max health to float values also thanks your a champion

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

69 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Health Regen Stop After Damage 1 Answer

Health Code, Damage and Healing 0 Answers

Health below zero but shows negative numbers 1 Answer

Help w/variables 0 Answers

Having a game object deal damage 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges