Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by Mseg14 · Apr 21, 2018 at 12:32 AM · transformnullreferenceexceptionfollowtarget

make a gameobject follow an array of targets

I wish to make a specific game object attack a specific target, and after that target is gone (Destroyed), go to the next closest target. As long as all the targets exists, my script works well enough, but once a target is destroyed.. the errors come flying in.


I have a public array of 3 targets (3 exactly, won't change), I calculate which one is closest to the gameobject, and it goes there (the "walking" works perfectly). I believe the issue is that even though the target has been destroyed, the array doesn't update itself (it's an update of transforms) so the function will always return the same transform.


Do you have an idea of how to solve this issue?

 using System;
 using UnityEngine;
 
 public class attack_target : MonoBehaviour {
 
     public Transform[] hearts;
     public float speed = 1f;
 
     private Transform target;
 
     // Use this for initialization
     void Start ()
     {
         target = GetClosestEnemy(hearts);
     }
 
     private Transform GetClosestEnemy(Transform[] hearts)
     {
         Transform bestTarget = null;
         float closestDistanceSqr = Mathf.Infinity;
         Vector3 currentPosition = this.transform.position;
         foreach (Transform potentialTarget in hearts)
         {
             Vector3 directionToTarget = potentialTarget.position - currentPosition;
             float dSqrToTarget = directionToTarget.sqrMagnitude;
             if (dSqrToTarget < closestDistanceSqr)
             {
                 closestDistanceSqr = dSqrToTarget;
                 bestTarget = potentialTarget;
             }
         }
 
         return bestTarget;
     }
 
     // Update is called once per frame
     void Update ()
     {
         while(target != null)
         {
             float step = speed * Time.deltaTime;
             transform.position = Vector3.MoveTowards(transform.position, target.position, step);
         }
 
         this.target = GetClosestEnemy(hearts);
     }
 }
 

 








Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
1
Best Answer

Answer by Nebukam · Apr 21, 2018 at 01:00 AM

Destroying a GameObject does not automatically erase the references to it (in this case, the reference inside your array of Transforms), you need to maintain the array yourself. An easy fix would be to update your GetClosestEnemy function like so :

 private Transform GetClosestEnemy(Transform[] hearts)
      {
          Transform bestTarget = null;
          float closestDistanceSqr = Mathf.Infinity;
          Vector3 currentPosition = this.transform.position;
          foreach (Transform potentialTarget in hearts)
          {
              if(potentialTarget == null){ continue; }
              
              Vector3 directionToTarget = potentialTarget.position - currentPosition;
              float dSqrToTarget = directionToTarget.sqrMagnitude;
              if (dSqrToTarget < closestDistanceSqr)
              {
                  closestDistanceSqr = dSqrToTarget;
                  bestTarget = potentialTarget;
              }
          }
  
          return bestTarget;
      }

the line if(potentialTarget == null){ continue; } will skip any destroyed Transform.

Note that is not an optimal solution, and rather than using a fixed-size array of transform, you'd be better using a List and just remove Transform from it as they are destroyed.


Edit : note that once all target have been destroyed, GetClosestEnemy() will return a null result, hence I would change the line this.target = GetClosestEnemy(hearts); by

 Transform tempTarget = GetClosestEnemy(hearts);
 if(tempTarget != null){  this.target = tempTarget; }
       


Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Mseg14 · Apr 21, 2018 at 11:57 AM 0
Share

Thank you so much for your help! it works perfectly.

Also, thank you for the explanation and not only for a solution.

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

101 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

(C#) Follow target (script) transform target PREFAB 0 Answers

It is not possible to invoke an expression of type 'UnityEngine.Vector3'. 1 Answer

Rotating Y towards X/Z 1 Answer

character controller that follow a target 1 Answer

NullReferenceException when i try to access the transform of the object i collided with 2 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges