Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by urhokekkonen5 · Apr 07, 2017 at 06:46 AM · editorcustom editorcustom-inspector

Null reference exceptions when using a Custom Editor

Hey,

I have this class:

 public class NarrativeMap : MonoBehaviour { 
 
     public LocalizationManager localizationManager;
     public Narrative[] narratives = new Narrative[0];
 
     ...
 }

which contains an array of references to a custom Narrative class. Narrative looks something like this:

 [System.Serializable]
 public class Narrative
 {
     private string id;
     private string xmlPath;
     private List<KeyValuePair<string, AudioClip>> audioClips;
 
     public Narrative(LocalizationManager mgr)
     {
         audioClips = new List<KeyValuePair<string, AudioClip>>();
         id = string.Empty;
         xmlPath = string.Empty;
 
         ...
 
     }

     ...
 
     private bool langExistsInClips(string langId)
     {
         foreach (var clip in audioClips)
         {
             if (clip.Key == langId)
                 return true;
         }
 
         return false;
     }

     ...
     
 }

The problem I am facing is that when I use the custom editor for NarrativeMap to modify and create new instances of the Narrative class and I call the various methods that do operations on the audioClips list, I get weird NullReference exceptions which basically state that the audioClips list in Narrative is not initialized. I don't understand how this is possible, as the list is initialized in the constructor and there should never be a case where the list is not initialized after the constructor has been called.

A snippet of the custom editor is here:

 [CustomEditor(typeof(NarrativeMap))]
 [CanEditMultipleObjects]
 public class NarrativeMapEditor : Editor {
 
 public override void OnInspectorGUI()
     {
         NarrativeMap narrativeMap = (NarrativeMap)target;
 
         narrativeMap.localizationManager = (LocalizationManager)EditorGUILayout.ObjectField("Localization manager", narrativeMap.localizationManager, typeof(LocalizationManager), true);
 
         int newLength = EditorGUILayout.IntField("Narrative count", narrativeMap.narratives.Length);
         newLength = newLength < 0 ? 0 : newLength;
 
         if (newLength < narrativeMap.narratives.Length)
         {
             Array.Resize(ref narrativeMap.narratives, newLength);
         }
         else if (newLength > narrativeMap.narratives.Length)
         {
             int origLength = narrativeMap.narratives.Length;
             Array.Resize(ref narrativeMap.narratives, newLength);
 
             for(int i = origLength; i < newLength; i++)
             {
                 narrativeMap.narratives[i] = new Narrative(narrativeMap.localizationManager);
             }
         }
 
         ...
 
         foreach (var narrative in narrativeMap.narratives)
         {
 
             narrative.updateClipList(narrativeMap.localizationManager);
 
             ...
 
         }

Sorry for the flood of code and thank you very much for any help.

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

0 Replies

· Add your reply
  • Sort: 

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

3 People are following this question.

avatar image avatar image avatar image

Related Questions

How can i get SerializedProperty from UnityEvent which in List. Sorry for my Eng. 2 Answers

Responsive Editor UI Button with custom style | How to remove GUIStyle.hover delay 0 Answers

Handles not displaying 1 Answer

Custom editor super slow even with no draw operations 1 Answer

Prefabs aren't saving with Undo.RecordObject 4 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges