Script to "apply & cancel debuff" effect only restores one value

Question

So basically I have obstacles spawn and when "Player" hits them their speed gets reduced and when the "Enemy" hits them I want him to stop moving for (waitTime); after waitTime the obstacle is destroyed.

For now it works all like a charm only when "Enemy" and "Player" hit the same obstacle, only playerSpeed is restored and on enemy.IsKinematic stays true.

Here is my code:

 private void OnTriggerEnter(Collider other)
 {
     if (other.tag == "Player" && gameManager.isGameActive == true)
     {
         SlowDownPlayer();       
     }
     else if (other.tag == "Enemy" && gameManager.isGameActive == true)
     {
         SlowDownEnemy();
     }
 }

 public void SlowDownPlayer()
 {
     Debug.Log("Splash");
     StartCoroutine(SlowDownInPuddle());
 }

 public IEnumerator SlowDownInPuddle()
 {
     player.gameObject.GetComponent<PlayerController>().playerSpeed = player.gameObject.GetComponent<PlayerController>().playerSpeed / 2;
     yield return new WaitForSecondsRealtime (waitTime);
     Destroy(gameObject);
     if (gameObject != null)
     {
         Debug.Log("player-speed restore");
         player.gameObject.GetComponent<PlayerController>().playerSpeed = player.gameObject.GetComponent<PlayerController>().playerSpeedInit;
     }
 }

 public void SlowDownEnemy()
 {
     Debug.Log("Slurp");
     StartCoroutine(SlowDownInPuddleEnemy());
 }

 public IEnumerator SlowDownInPuddleEnemy()
 {
     enemy.gameObject.GetComponent<Rigidbody>().isKinematic = true;
     yield return new WaitForSeconds(waitTime);
     Destroy(gameObject);
     if (gameObject != null)
     {
         Debug.Log("enemy-kinematic = false");
         enemy.gameObject.GetComponent<Rigidbody>().isKinematic = false;
     }
         
 }

Answer 1

Something looks wrong with your code. How do you set the value of player and enemy? I believe they are not the references you get from OnTriggerEnter. And destroying the gameObject before the end of the coroutine may abort the coroutine (the destroy happens after the yield so maybe not).

  private void OnTriggerEnter(Collider other)
  {
      if (other.CompareTag("Player") && gameManager.isGameActive)
      {
          StartCoroutine(SlowDownInPuddle(other.gameObject));       
      }
      else if (other.CompareTag("Enemy") && gameManager.isGameActive)
      {
          StartCoroutine(SlowDownInPuddleEnemy(other.gameObject));
      }
  }
  
  private IEnumerator SlowDownInPuddle(GameObject player)
  {
      PlayerController playerController = player.GetComponent<PlayerController>();
      playerController.playerSpeed *= 0.5f;
      yield return new WaitForSecondsRealtime (waitTime);
      Debug.Log("player-speed restore");
      playerController.playerSpeed = playerController.playerSpeedInit;
      Destroy(gameObject);
  }
   private IEnumerator SlowDownInPuddleEnemy(GameObject enemy)
  {
      Rigidbody enemyRigidbody = enemy.GetComponent<Rigidbody>();
      enemyRigidbody.isKinematic = true;
      yield return new WaitForSeconds(waitTime);
      Debug.Log("enemy-kinematic = false");
      enemyRigidbody.isKinematic = false;
      Destroy(gameObject);
  }

Answer 2

Hey, thanks for your answer! I checked your code and I still have the same error; when player hits the Puddle and Enemy does so too, playerSpeed is restored but enemy.IsKinematic == true. And Vice versa if enemy hits first and player second.

To give you a little bit more context: I have a prefab spawning with the script applied. If either player or enemy hits the obstacle the code worked just fine, just when both are hitting the same object, the first value changed (playerSpeed or IsKinematic) and the second one is not. I feel like it has to do something with the gameObject being destroyed too soon, so I figured I could call if (gameObject != null) and then "isKinematic = false" and "playerSpeed = playerSpeedInit;" which should apply the if statement, when the object is destroyed. I might be mistaken on that one so maybe that's where the problem is. Let me post more of my code:

     {
     gameManager = GameObject.Find("GameManager").GetComponent<GameManager>();
     player = GameObject.Find("Player");
     enemy = GameObject.Find("Enemy");
     }
     void Start()
     {
         gameManager = GameObject.Find("GameManager").GetComponent<GameManager>();
         player = GameObject.Find("Player");
         enemy = GameObject.Find("Enemy");
     }

Looking forward to your reply and I really hope I or we can solve this :)

Script to "apply & cancel debuff" effect only restores one value

2 Replies

Your answer

Follow this Question

Related Questions