Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by Dreik100 · Dec 26, 2016 at 09:21 PM · c#uispriteimagenull

Why is Sprite a null?

So I have classes: Item , Weapon that inherits from Item , ItemFactory and some InventoryController. Code:

 public class Item : MonoBehaviour {
       protected float scale = 1;
       public float Scale { get
         {
           return scale;
         }
       }
       protected int id;
       protected int rarity;
       static protected Sprite sprite;
     
       public Item()
       {
         id = -1;
       }
     
       public Item(int id)
       {
         this.id = id;
       }
     
       public bool IsEmpty()
       {
         if(this.id==-1) return true;
         return false;
       }
     
       public Sprite getSprite()
       {
         return sprite;
       }
     
     }

 public class Weapon : Item{
 
   public Weapon()
   {
     scale = 0.25f;
     id = 1;
   }     
   void Awake()
   {
     sprite = GetComponent<Image>().sprite;
   }
 
 }




InventoryController calls to ItemFactory to make Item for it and then I use this code to set Item into inventory:

 public void AddItem(Item item)
   {
     for(int i=0; i<slotAmount; i++)
     {
       if (items[i].IsEmpty())
       {
         items[i] = item;
         GameObject itemObj = Instantiate(inventoryItem); // Its empty item prefab
         itemObj.transform.SetParent(slots[i].transform);
         itemObj.transform.position = slots[i].transform.position;
         itemObj.GetComponent<Image>().sprite = item.getSprite();
         itemObj.transform.localScale = new Vector3(item.Scale, item.Scale);
         return;
       }
     }
   }
 


Even thought scale comes right the sprite I get is null. Tried to Debug it and item.getType() returns "Weapon" if ItemFactory returns new Weapon. So the Question is why sprite I set to this item is null? I call the itemFactory like this:

 ItemFactory itemFactory = new ItemFactory();
 AddItem(itemFactory.makeItem(1)); // makeItem(int type) returns the Item of type Weapon if type == 1

 





Comment
Add comment · Show 4
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image UnityCoach · Dec 26, 2016 at 09:33 PM 0
Share

Why is the sprite property "static"?

avatar image Dreik100 · Dec 27, 2016 at 10:57 AM 0
Share

I want every object of type Weapon to have the same sprite. Because its just for educational purpouses.

avatar image tanoshimi · Dec 27, 2016 at 11:07 AM 1
Share

You declare sprite on line 10, but I don't see anywhere where you ever assign a value to it, so getSprite is just going to return null.

avatar image Dreik100 tanoshimi · Dec 27, 2016 at 11:41 AM 0
Share

Look closely:
void Awake() { sprite = GetComponent().sprite; } Also Script is attached to UI->Image prefab

0 Replies

· Add your reply
  • Sort: 

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

9 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

How to make a UI image change sprite through a script that is not attached to the UI image itself 0 Answers

How to snap UI element anchor relative to image sprite? 2 Answers

Multiple Cars not working 1 Answer

C# making an optimized UI 1 Answer

Error facebook profile picture 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges