Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
  • Help Room /
avatar image
0
Question by grzesiu10 · Nov 08, 2015 at 06:32 AM · spritesbuttonsbutton trigger eventsbutton backround

Can't change sprite image of a button

I want to change button Source Image via OnClick event but it doesn't work. The public function is attached to the button which image i want to change. Here's code:

 Sprite sOff, sOn;
 
 void Start () {
         sOn = Resources.Load<Sprite>("soundon1");
         sOff = Resources.Load<Sprite>("soundoff");
 if (reference.AudioOn == true)
                 button.image.sprite = sOn;
             else
                 button.image.sprite = sOff;
 }
 
 public void ChangeSprite() {
         if (button.image.sprite == sOn)
             button.image.sprite = sOff;
         if (button.image.sprite == sOff)
             button.image.sprite = sOn;
     }

Sprites are loading fine. Changing sprite works in Start function but I can't do it by clicking on the button. Any ideas why?

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
1
Best Answer

Answer by OncaLupe · Nov 08, 2015 at 10:22 PM

You're checking to see if the current sprite is set to the 'on' sprite, and if it is then setting it to 'off'. This is fine, however you're then checking to see if it's 'off' and setting it to 'on'. Since you just got done setting it to off this will always trigger. You need to use an 'else' in there, like this:

 public void ChangeSprite() {
          if (button.image.sprite == sOn)
              button.image.sprite = sOff;
          else if (button.image.sprite == sOff)
              button.image.sprite = sOn;
      }

or, since it's just two possible states, can simplify a bit like this:

 public void ChangeSprite() {
          if (button.image.sprite == sOn)
              button.image.sprite = sOff;
          else
              button.image.sprite = sOn;
      }

Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image grzesiu10 · Nov 10, 2015 at 07:29 PM 0
Share

thank you! :)

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

4 People are following this question.

avatar image avatar image avatar image avatar image

Related Questions

Pause Menu not working ;-; 2 Answers

Buttons won't get interaction in instantiated prefab 0 Answers

Restarting the scene when button is pressed 3 Answers

Unity 5.3.4f1 Inconsistent Animation times between mobile devices. 0 Answers

GVR reticle do not hover on buttons, and the click only work outside of button shape 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges