Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by ultimate35 · Jun 29, 2017 at 11:31 AM · c#errorcharactercharactercontrollercomponent

Object reference not set to an instance of an Object

using UnityEngine; using System.Collections;

public class PlayerController : MonoBehaviour {

 public GameObject playerObject;


 public float walkSpeed = 2;
 public float runSpeed = 6;
 public float gravity = -12;
 public float jumpHeight = 1;
 [Range(0,1)]
 public float airControlPercent;

 public float turnSmoothTime = 0.2f;
 float turnSmoothVelocity;

 public float speedSmoothTime = 0.1f;
 float speedSmoothVelocity;
 float currentSpeed;
 float velocityY;

 Animator animator;
 Transform cameraT;
 CharacterController controller;

 void Start () {
     animator = GetComponent<Animator> ();
     cameraT = Camera.main.transform;
     controller = GetComponent<CharacterController> ();
 }

 void Update () {
     // input
     Vector2 input = new Vector2 (Input.GetAxisRaw ("Horizontal"), Input.GetAxisRaw ("Vertical"));
     Vector2 inputDir = input.normalized;
     bool running = Input.GetKey (KeyCode.LeftShift);

     Move (inputDir, running);

     if (Input.GetKeyDown (KeyCode.Space)) {
         Jump ();
     }
     // animator
     float animationSpeedPercent = ((running) ? currentSpeed / runSpeed : currentSpeed / walkSpeed * .5f);
     animator.SetFloat ("speedPercent", animationSpeedPercent, speedSmoothTime, Time.deltaTime);

 }

 void Move(Vector2 inputDir, bool running) {
     if (inputDir != Vector2.zero) {
         float targetRotation = Mathf.Atan2 (inputDir.x, inputDir.y) * Mathf.Rad2Deg + cameraT.eulerAngles.y;
         transform.eulerAngles = Vector3.up * Mathf.SmoothDampAngle(transform.eulerAngles.y, targetRotation, ref turnSmoothVelocity, GetModifiedSmoothTime(turnSmoothTime));
     }
         
     float targetSpeed = ((running) ? runSpeed : walkSpeed) * inputDir.magnitude;
     currentSpeed = Mathf.SmoothDamp (currentSpeed, targetSpeed, ref speedSmoothVelocity, GetModifiedSmoothTime(speedSmoothTime));

     velocityY += Time.deltaTime * gravity;
     Vector3 velocity = transform.forward * currentSpeed + Vector3.up * velocityY;

     controller.Move (velocity * Time.deltaTime);
     currentSpeed = new Vector2 (controller.velocity.x, controller.velocity.z).magnitude;

     if (controller.isGrounded) {
         velocityY = 0;
     }

 }

 void Jump() {
     if (controller.isGrounded) {
         float jumpVelocity = Mathf.Sqrt (-2 * gravity * jumpHeight);
         velocityY = jumpVelocity;
     }
 }

 float GetModifiedSmoothTime(float smoothTime) {
     if (controller.isGrounded) {
         return smoothTime;
     }

     if (airControlPercent == 0) {
         return float.MaxValue;
     }
     return smoothTime / airControlPercent;
 }

}

![alt text][1] [1]: /storage/temp/96810-2017-06-29-4.png

Whats the problem ? I can add the this code and it gave the error

2017-06-29-4.png (36.4 kB)
Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
0

Answer by cbjunior · Jun 29, 2017 at 01:12 PM

It seems like your script isn't finding the CharacterController component. Are you sure you have one attached to your object that the script is attached to?

One good error checking practice for scripts is to check to make sure that the component is actually found by the script.

 controller = GetComponent<CharacterController>();
 
 if (!controller) //Check for controller reference
 {
      Debug.LogError("Didn't find CharacterController");
 }
Comment
Add comment · Show 4 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image ShadyProductions · Jun 29, 2017 at 05:23 PM 0
Share

controller is not a boolean, so you cannot just do if (!controller) You will have to use if (controller != null)

avatar image cbjunior · Jun 29, 2017 at 09:54 PM 0
Share

@ShadyProductions All the classes derived from Component overload the ! operator, so you can use them like a boolean.

avatar image cbjunior · Jun 29, 2017 at 09:55 PM 0
Share

I've done it with dozens of scripts

avatar image cbjunior · Jun 29, 2017 at 09:57 PM 0
Share

https://docs.unity3d.com/ScriptReference/Component.html Look under operators, you will see bool

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

360 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Base Character error 1 Answer

How can I have a CharacterController's height make it to where the feet are correctly on the ground? 0 Answers

How do I solve this error? 2 Answers

fps script not working 1 Answer

[C#]CharacterController Turning 2 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges